Bug 86123 – IndexedDB: Implement spec behavior for multiEntry indexes with invalid/duplicate subkeys

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Joshua Bell]

The spec details the handling of multiEntry key paths where the key path yields an array and the array includes values that are duplicates or invalid sub-keys. WebKit's implementation (WebCore/binding/v8/IDBBindingUtilities.cpp) yields an overall InvalidType key if any of the subkeys are invalid.

http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#dfn-steps-for-storing-a-record-into-an-object-store

7.4 If index's multiEntry flag is true, and index key is an Array, remove any elements from index key that are not valid keys and remove any duplicate elements from index key such that only one instance of the duplicate value remains.

For example, the following value of index key [10, 20, null, 30, 20] is converted to [10, 20, 30].

[Alec Flett]

Created attachment 148395 [details]
Patch

[Alec Flett]

jsbell@ or dgrogan@ - mind a quick look?

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Alec Flett]

Created attachment 148414 [details]
Patch

[Joshua Bell]

Comment on attachment 148414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148414&action=review

> Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp:393
> +        ASSERT_NOT_REACHED();

Redundant with fall through.

> Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:451
> +                if (!m_index->addingKeyAllowed(indexKey->array()[i].get()))

Ouch, good catch.

> LayoutTests/storage/indexeddb/resources/index-multientry.js:124
> +                                         };

Either put this callback all on one line, or correct the indentation.

[Alec Flett]

Created attachment 148425 [details]
Patch

[Alec Flett]

Comment on attachment 148425 [details]
Patch

tkent@ - r? cq?

[Alec Flett]

Created attachment 148848 [details]
Patch

[Joshua Bell]

Created attachment 148851 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 148851 [details]
Patch for landing

Clearing flags on attachment: 148851

Committed r120967: <http://trac.webkit.org/changeset/120967>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.