Bug 89458 - [EFL] Enable SUBPIXEL_LAYOUT feature flag for EFL
Summary: [EFL] Enable SUBPIXEL_LAYOUT feature flag for EFL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominik Röttsches (drott)
URL:
Keywords: WebExposed
Depends on: 89572 90169 102374 103121 103129 106774 107548
Blocks: 85532
  Show dependency treegraph
 
Reported: 2012-06-19 04:23 PDT by Dominik Röttsches (drott)
Modified: 2013-01-22 10:05 PST (History)
9 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Röttsches (drott) 2012-06-19 04:23:58 PDT
We'd like to follow suit with bug 85532, enabling sub-pixel layout for the EFL port.
Comment 1 Dominik Röttsches (drott) 2012-06-20 06:10:40 PDT
First obstacle, in a number of cases
setLogicalTop(roundToInt(top + maxAscent - fontMetrics.ascent(baselineType)));
inside
InlineFlowBox::placeBoxesInBlockDirection
actually results in -1.

maxAscent is 840/60 = 14, while fontMetrics.ascent (and fontMetrics.floatAscent fwiw) return 15.

Will investigate - but if you have any ideas, Levi, Emil - let me know.
Comment 2 Dominik Röttsches (drott) 2012-06-20 06:20:27 PDT
(In reply to comment #1)
> First obstacle, in a number of cases
> setLogicalTop(roundToInt(top + maxAscent - fontMetrics.ascent(baselineType)));
> inside
> InlineFlowBox::placeBoxesInBlockDirection
> actually results in -1.

To clarify: ...leading to hundreds of test cases failing to show expected results just by this -1 offset - they previously had the logialTop just at 0.
Comment 3 Dominik Röttsches (drott) 2013-01-19 12:45:26 PST
Freetype updated and feature enabled in bug 106774, new baselines completely uploaded and the bots are returning back to normal. Closing bug.
Comment 4 Dominik Röttsches (drott) 2013-01-19 15:43:43 PST
Big thanks, Thiago, for helping with the rebaselines!
Comment 5 Emil A Eklund 2013-01-22 10:05:42 PST
Awesome, thanks for making this happen Dominik!