Bug 107548 - [EFL] Enable sub-pixel tests
Summary: [EFL] Enable sub-pixel tests
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominik Röttsches (drott)
Depends on:
Blocks: 89458
  Show dependency treegraph
Reported: 2013-01-22 04:10 PST by Dominik Röttsches (drott)
Modified: 2013-01-22 05:27 PST (History)
7 users (show)

See Also:

Patch (37.86 KB, patch)
2013-01-22 04:33 PST, Dominik Röttsches (drott)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Röttsches (drott) 2013-01-22 04:10:12 PST
I'd like to enable sub-pixel tests for EFL -
however the "fast/sub-pixel" directory is skipped in platform/wk2/TestExpectations.
I am removing it there, and pushing it to the more specific TestExpectations files for ports that don't run them.
Comment 1 Dominik Röttsches (drott) 2013-01-22 04:33:01 PST
Created attachment 183964 [details]
Comment 2 WebKit Review Bot 2013-01-22 04:36:39 PST
Attachment 183964 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/efl/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png:0:  Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png").  [image/png] [5]
Total errors found: 1 in 8 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dominik Röttsches (drott) 2013-01-22 04:38:54 PST
Alan, I think you need to adjust the SVN mime type setting on your style checker bot. Thanks.
Comment 4 WebKit Review Bot 2013-01-22 05:27:55 PST
Comment on attachment 183964 [details]

Clearing flags on attachment: 183964

Committed r140416: <http://trac.webkit.org/changeset/140416>
Comment 5 WebKit Review Bot 2013-01-22 05:27:59 PST
All reviewed patches have been landed.  Closing bug.