WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
107548
[EFL] Enable sub-pixel tests
https://bugs.webkit.org/show_bug.cgi?id=107548
Summary
[EFL] Enable sub-pixel tests
Dominik Röttsches (drott)
Reported
2013-01-22 04:10:12 PST
I'd like to enable sub-pixel tests for EFL - however the "fast/sub-pixel" directory is skipped in platform/wk2/TestExpectations. I am removing it there, and pushing it to the more specific TestExpectations files for ports that don't run them.
Attachments
Patch
(37.86 KB, patch)
2013-01-22 04:33 PST
,
Dominik Röttsches (drott)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dominik Röttsches (drott)
Comment 1
2013-01-22 04:33:01 PST
Created
attachment 183964
[details]
Patch
WebKit Review Bot
Comment 2
2013-01-22 04:36:39 PST
Attachment 183964
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/platform/efl/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png:0: Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dominik Röttsches (drott)
Comment 3
2013-01-22 04:38:54 PST
Alan, I think you need to adjust the SVN mime type setting on your style checker bot. Thanks.
WebKit Review Bot
Comment 4
2013-01-22 05:27:55 PST
Comment on
attachment 183964
[details]
Patch Clearing flags on attachment: 183964 Committed
r140416
: <
http://trac.webkit.org/changeset/140416
>
WebKit Review Bot
Comment 5
2013-01-22 05:27:59 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug