Bug 89447 – [JSC] Implement support for JSDictionary::convertValue(Vector<String>& result)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Chris Dumez]

Without JSDictionary::convertValue(Vector<String>& result), the IndexedDB code is not compiling for JSC.

This is needed for these line to compile:
  Vector<String> keyPathArray;
  if (options.get("keyPath", keyPathArray))
in IDBDatabase::createObjectStore().

[Chris Dumez]

Created attachment 148284 [details]
Patch

[Adam Barth]

Comment on attachment 148284 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148284&action=review

> Source/WebCore/bindings/js/JSDictionary.cpp:110
> +    unsigned length;

unsigned -> size_t, right?

[Chris Dumez]

(In reply to comment #2)
> (From update of attachment 148284 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148284&action=review
> 
> > Source/WebCore/bindings/js/JSDictionary.cpp:110
> > +    unsigned length;
> 
> unsigned -> size_t, right?

No, the method I'm calling is defined as:
Source/WebCore/bindings/js/JSDOMBinding.h:
JSC::JSObject* toJSSequence(JSC::ExecState*, JSC::JSValue, unsigned&);

[Chris Dumez]

Comment on attachment 148284 [details]
Patch

Setting back cq? flag after double checking.

[Chris Dumez]

Could someone please cq+?

[WebKit Review Bot]

Comment on attachment 148284 [details]
Patch

Clearing flags on attachment: 148284

Committed r120719: <http://trac.webkit.org/changeset/120719>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.