Without JSDictionary::convertValue(Vector<String>& result), the IndexedDB code is not compiling for JSC. This is needed for these line to compile: Vector<String> keyPathArray; if (options.get("keyPath", keyPathArray)) in IDBDatabase::createObjectStore().
Created attachment 148284 [details] Patch
Comment on attachment 148284 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148284&action=review > Source/WebCore/bindings/js/JSDictionary.cpp:110 > + unsigned length; unsigned -> size_t, right?
(In reply to comment #2) > (From update of attachment 148284 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=148284&action=review > > > Source/WebCore/bindings/js/JSDictionary.cpp:110 > > + unsigned length; > > unsigned -> size_t, right? No, the method I'm calling is defined as: Source/WebCore/bindings/js/JSDOMBinding.h: JSC::JSObject* toJSSequence(JSC::ExecState*, JSC::JSValue, unsigned&);
Comment on attachment 148284 [details] Patch Setting back cq? flag after double checking.
Could someone please cq+?
Comment on attachment 148284 [details] Patch Clearing flags on attachment: 148284 Committed r120719: <http://trac.webkit.org/changeset/120719>
All reviewed patches have been landed. Closing bug.