Bug 89426 - [Qt] REGRESSION(r120624): It made fast/text/line-breaks-after-ideographic-comma-or-full-stop.html fail on non-ICU platforms
Summary: [Qt] REGRESSION(r120624): It made fast/text/line-breaks-after-ideographic-com...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 79666 87041
  Show dependency tree / graph
 
Reported: 2012-06-18 23:05 PDT by Csaba Osztrogonác
Modified: 2014-02-01 19:00 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-06-18 23:05:34 PDT 
http://trac.webkit.org/changeset/120624 made fast/text/line-breaks-after-ideographic-comma-or-full-stop.html fail on Qt:


--- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/text/line-breaks-after-ideographic-comma-or-full-stop-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/text/line-breaks-after-ideographic-comma-or-full-stop-actual.txt 
@@ -15,4 +15,4 @@
 
 ăătexttexttexttext
 
-PASS
+FAIL


Could you check it, please?
Comment 1 Csaba Osztrogonác 2012-06-18 23:10:20 PDT 
I skipped it to paint the bot green - http://trac.webkit.org/changeset/120677/trunk/LayoutTests/platform/qt/Skipped

Please unskip it with the proper fix. Thanks.
Comment 2 mitz 2012-06-18 23:13:31 PDT 
(In reply to comment #0)
> http://trac.webkit.org/changeset/120624 made fast/text/line-breaks-after-ideographic-comma-or-full-stop.html fail on Qt:
> 
> 
> --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/text/line-breaks-after-ideographic-comma-or-full-stop-expected.txt 
> +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/text/line-breaks-after-ideographic-comma-or-full-stop-actual.txt 
> @@ -15,4 +15,4 @@
> 
>  ăătexttexttexttext
> 
> -PASS
> +FAIL
> 
> 
> Could you check it, please?

I guess the configuration failing this new test isn’t using ICU at all.
Comment 3 Csaba Osztrogonác 2012-06-18 23:21:59 PDT 
Oh it is a new test, and not regression.
Comment 4 Csaba Osztrogonác 2012-06-18 23:44:55 PDT 
You confused me a little bit. :) There are two different bugs here:
- r120624 made fast/text/line-breaks-after-ideographic-comma-or-full-stop.html fail (it is an old test) on Qt 4.8 which is non-ICU platform.
- The new fast/text/line-breaks-after-ideographic-comma-or-full-stop-2.html fails on Qt 5 whihc is ICU platform. (I'm going to file a new bug for it.)
Comment 5 Csaba Osztrogonác 2012-06-18 23:54:11 PDT 
I skipped it on the non-ICU Qt4 platform - http://trac.webkit.org/changeset/120682/trunk/LayoutTests/platform/qt-4.8/Skipped

The new bug on the other fail is https://bugs.webkit.org/show_bug.cgi?id=89436