Bug 89357 – REGRESSION(r120592): Broke v8 bindings on windows. (Requested by atwilson__ on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/120592 broke the build:
Broke v8 bindings on windows. (Requested by atwilson__ on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 148114 [details]
ROLLOUT of r120592

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Andrew Wilson]

Got this error compiling v8 bindings on win:


511>..\bindings\v8\JavaScriptCallFrame.cpp(131): error C2466: cannot allocate an array of constant size 0
511>..\bindings\v8\JavaScriptCallFrame.cpp(131): error C2440: 'initializing' : cannot convert from 'int' to 'v8::Handle<T>'
511>          with
511>          [
511>              T=v8::Value
511>          ]
511>          Constructor for class 'v8::Handle<T>' is declared 'explicit'
511>          with
511>          [
511>              T=v8::Value
511>          ]

[WebKit Review Bot]

Comment on attachment 148114 [details]
ROLLOUT of r120592

Clearing flags on attachment: 148114

Committed r120606: <http://trac.webkit.org/changeset/120606>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.