'Restart frame' is a debugger action that starts selected function (stack frame) from the beginning and drops completely all stack frames above it. Add its support to remote debugging protocol and implement it in Inspector backend.
Created attachment 147708 [details] Patch
Attachment 147708 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InjectedScript.cpp:98: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InjectedScript.h:84: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 147708 [details] Patch Attachment 147708 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12952769
Comment on attachment 147708 [details] Patch Attachment 147708 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12950882
Comment on attachment 147708 [details] Patch Attachment 147708 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12957533
Comment on attachment 147708 [details] Patch Attachment 147708 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12953757
Comment on attachment 147708 [details] Patch Attachment 147708 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12966219
Comment on attachment 147708 [details] Patch Attachment 147708 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12960435
Comment on attachment 147708 [details] Patch Attachment 147708 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12954596
Comment on attachment 147708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147708&action=review > Source/WebCore/bindings/v8/DebuggerScript.js:261 > + function restart() { Please move { to the next line. > Source/WebCore/bindings/v8/ScriptFunctionCall.cpp:136 > + V8RecursionScope innerScope(getScriptExecutionContext()); why did this change? > Source/WebCore/inspector/JavaScriptCallFrame.idl:42 > + [Custom] InspectorObject restart(); No need for Custom here.
Comment on attachment 147708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147708&action=review > Source/WebCore/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:49 > +v8::Handle<v8::Value> V8JavaScriptCallFrame::restartCallback(const v8::Arguments& args) You don't need this. > Source/WebCore/inspector/Inspector.json:2439 > + "name": "restartFrame", "hidden": true > Source/WebCore/inspector/Inspector.json:2444 > + { "name": "callFrames", "type": "array", "optional": true, "items": { "$ref": "CallFrame"}, "description": "New stack trace." }, Should not be optional. > Source/WebCore/inspector/Inspector.json:2445 > + { "name": "result", "type": "object", "optional": true, "description": "VM-specific description of the changes applied.", "hidden": true } Should not be optional. Nuke the "changes applied part".
Created attachment 147994 [details] Patch
Attachment 147994 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InjectedScript.cpp:98: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InjectedScript.h:84: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #10) > (From update of attachment 147708 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=147708&action=review > > > Source/WebCore/bindings/v8/DebuggerScript.js:261 > > + function restart() { > > Please move { to the next line. Done > > Source/WebCore/bindings/v8/ScriptFunctionCall.cpp:136 > > + V8RecursionScope innerScope(getScriptExecutionContext()); > why did this change? Rename variable that shadows another variable with the same name in this function. > > Source/WebCore/inspector/JavaScriptCallFrame.idl:42 > > + [Custom] InspectorObject restart(); > No need for Custom here. Custom is kept, binding scripts otherwise won't let return V8 Value.
Comment on attachment 147994 [details] Patch Attachment 147994 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12974067
Comment on attachment 147994 [details] Patch Attachment 147994 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12965821
Created attachment 147996 [details] Patch
Attachment 147996 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InjectedScript.cpp:98: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InjectedScript.h:84: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 147996 [details] Patch Attachment 147996 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12970325
Comment on attachment 147996 [details] Patch Attachment 147996 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12959999
Created attachment 148040 [details] Patch
Attachment 148040 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InjectedScript.cpp:98: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InjectedScript.h:84: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 148040 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148040&action=review > Source/WebCore/bindings/v8/ScriptDebugServer.cpp:260 > + // Call stack may have changed after if the edited function was on the stack. after -> after script editing, I think making currentCallFrame() public would also be fine.
Created attachment 148085 [details] Patch
Attachment 148085 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InjectedScript.cpp:98: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InjectedScript.h:84: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 148085 [details] Patch Clearing flags on attachment: 148085 Committed r120592: <http://trac.webkit.org/changeset/120592>
All reviewed patches have been landed. Closing bug.
Re-opened since this is blocked by 89357
Created attachment 148123 [details] Fix win build
Attachment 148123 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InjectedScript.cpp:98: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InjectedScript.h:84: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
FYI > Source/WebCore/inspector/compile-front-end.py 0 error(s), 0 warning(s), 77.6% typed Compiling InjectedScriptSource.js... Source/WebCore/inspector/InjectedScriptSourceTmp.js:381: WARNING - Property restart never defined on callFrame var result = callFrame.restart(); ^ 0 error(s), 1 warning(s), 66.0% typed
Comment on attachment 148123 [details] Fix win build Please fix the closure compiler warning prior to landing.
Created attachment 148317 [details] Patch
Attachment 148317 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InjectedScript.cpp:98: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InjectedScript.h:84: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 148317 [details] Patch Clearing flags on attachment: 148317 Committed r120709: <http://trac.webkit.org/changeset/120709>