Bug 89147 – Web Inspector: Support 'Restart frame' in protocol and backend

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Peter Rybin]

'Restart frame' is a debugger action that starts selected function (stack frame) from the beginning and drops completely all stack frames above it.
Add its support to remote debugging protocol and implement it in Inspector backend.

[Peter Rybin]

Created attachment 147708 [details]
Patch

[WebKit Review Bot]

Attachment 147708 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:98:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:84:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gustavo Noronha (kov)]

Comment on attachment 147708 [details]
Patch

Attachment 147708 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12952769

[Early Warning System Bot]

Comment on attachment 147708 [details]
Patch

Attachment 147708 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12950882

[Build Bot]

Comment on attachment 147708 [details]
Patch

Attachment 147708 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12957533

[Early Warning System Bot]

Comment on attachment 147708 [details]
Patch

Attachment 147708 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12953757

[Gyuyoung Kim]

Comment on attachment 147708 [details]
Patch

Attachment 147708 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12966219

[Build Bot]

Comment on attachment 147708 [details]
Patch

Attachment 147708 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12960435

[Early Warning System Bot]

Comment on attachment 147708 [details]
Patch

Attachment 147708 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12954596

[Pavel Feldman]

Comment on attachment 147708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147708&action=review

> Source/WebCore/bindings/v8/DebuggerScript.js:261
> +    function restart() {

Please move { to the next line.

> Source/WebCore/bindings/v8/ScriptFunctionCall.cpp:136
> +        V8RecursionScope innerScope(getScriptExecutionContext());

why did this change?

> Source/WebCore/inspector/JavaScriptCallFrame.idl:42
> +        [Custom] InspectorObject restart();

No need for Custom here.

[Pavel Feldman]

Comment on attachment 147708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147708&action=review

> Source/WebCore/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:49
> +v8::Handle<v8::Value> V8JavaScriptCallFrame::restartCallback(const v8::Arguments& args)

You don't need this.

> Source/WebCore/inspector/Inspector.json:2439
> +                "name": "restartFrame",

"hidden": true

> Source/WebCore/inspector/Inspector.json:2444
> +                    { "name": "callFrames", "type": "array", "optional": true, "items": { "$ref": "CallFrame"}, "description": "New stack trace." },

Should not be optional.

> Source/WebCore/inspector/Inspector.json:2445
> +                    { "name": "result", "type": "object", "optional": true, "description": "VM-specific description of the changes applied.", "hidden": true }

Should not be optional. Nuke the "changes applied part".

[Peter Rybin]

Created attachment 147994 [details]
Patch

[WebKit Review Bot]

Attachment 147994 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:98:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:84:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Peter Rybin]

(In reply to comment #10)
> (From update of attachment 147708 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=147708&action=review
> 
> > Source/WebCore/bindings/v8/DebuggerScript.js:261
> > +    function restart() {
> 
> Please move { to the next line.
Done

> > Source/WebCore/bindings/v8/ScriptFunctionCall.cpp:136
> > +        V8RecursionScope innerScope(getScriptExecutionContext());
> why did this change?

Rename variable that shadows another variable with the same name in this function.

> > Source/WebCore/inspector/JavaScriptCallFrame.idl:42
> > +        [Custom] InspectorObject restart();
> No need for Custom here.

Custom is kept, binding scripts otherwise won't let return V8 Value.

[Build Bot]

Comment on attachment 147994 [details]
Patch

Attachment 147994 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12974067

[WebKit Review Bot]

Comment on attachment 147994 [details]
Patch

Attachment 147994 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12965821

[Peter Rybin]

Created attachment 147996 [details]
Patch

[WebKit Review Bot]

Attachment 147996 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:98:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:84:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 147996 [details]
Patch

Attachment 147996 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12970325

[Build Bot]

Comment on attachment 147996 [details]
Patch

Attachment 147996 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12959999

[Peter Rybin]

Created attachment 148040 [details]
Patch

[WebKit Review Bot]

Attachment 148040 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:98:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:84:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yury Semikhatsky]

Comment on attachment 148040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148040&action=review

> Source/WebCore/bindings/v8/ScriptDebugServer.cpp:260
> +    // Call stack may have changed after if the edited function was on the stack.

after -> after script editing, I think making currentCallFrame() public would also be fine.

[Peter Rybin]

Created attachment 148085 [details]
Patch

[WebKit Review Bot]

Attachment 148085 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:98:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:84:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 148085 [details]
Patch

Clearing flags on attachment: 148085

Committed r120592: <http://trac.webkit.org/changeset/120592>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

Re-opened since this is blocked by 89357

[Peter Rybin]

Created attachment 148123 [details]
Fix win build

[WebKit Review Bot]

Attachment 148123 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:98:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:84:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andrey Adaikin]

FYI

> Source/WebCore/inspector/compile-front-end.py
0 error(s), 0 warning(s), 77.6% typed
Compiling InjectedScriptSource.js...
Source/WebCore/inspector/InjectedScriptSourceTmp.js:381: WARNING - Property restart never defined on callFrame
        var result = callFrame.restart();
                     ^

0 error(s), 1 warning(s), 66.0% typed

[Yury Semikhatsky]

Comment on attachment 148123 [details]
Fix win build

Please fix the closure compiler warning prior to landing.

[Peter Rybin]

Created attachment 148317 [details]
Patch

[WebKit Review Bot]

Attachment 148317 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:98:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:84:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 148317 [details]
Patch

Clearing flags on attachment: 148317

Committed r120709: <http://trac.webkit.org/changeset/120709>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.