Bug 89324 - [TextureMapper] Rename shader variables to match the naming scheme of the newer filter shaders
Summary: [TextureMapper] Rename shader variables to match the naming scheme of the new...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on: 89317
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-17 22:31 PDT by Martin Robinson
Modified: 2012-06-18 13:36 PDT (History)
2 users (show)

See Also:


Attachments
Patch (10.28 KB, patch)
2012-06-17 22:48 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cq-03 (1.12 MB, application/zip)
2012-06-18 11:40 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2012-06-17 22:31:55 PDT
The newer filter shaders use a naming scheme much like the one that the Chromium compositor uses. It makes sense to bring the older shaders in line with this scheme.
Comment 1 Martin Robinson 2012-06-17 22:48:27 PDT
Created attachment 148055 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-18 11:40:45 PDT
Comment on attachment 148055 [details]
Patch

Rejecting attachment 148055 [details] from commit-queue.

New failing tests:
http/tests/security/script-crossorigin-loads-correctly.html
Full output: http://queues.webkit.org/results/12979226
Comment 3 WebKit Review Bot 2012-06-18 11:40:50 PDT
Created attachment 148139 [details]
Archive of layout-test-results from ec2-cq-03

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 4 WebKit Review Bot 2012-06-18 13:36:04 PDT
Comment on attachment 148055 [details]
Patch

Clearing flags on attachment: 148055

Committed r120623: <http://trac.webkit.org/changeset/120623>
Comment 5 WebKit Review Bot 2012-06-18 13:36:09 PDT
All reviewed patches have been landed.  Closing bug.