Bug 89317 - [TextureMapper] Replace the source transform with a flip uniform
Summary: [TextureMapper] Replace the source transform with a flip uniform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on: 89293
Blocks: 89324
  Show dependency treegraph
 
Reported: 2012-06-17 16:13 PDT by Martin Robinson
Modified: 2012-06-18 10:24 PDT (History)
2 users (show)

See Also:


Attachments
Patch (8.82 KB, patch)
2012-06-17 22:27 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2012-06-17 16:13:08 PDT
Instead of passing an entire transformation matrix to flip source textures, it should be enough to simply pass a single float denoting whether or not to flip the texture. This will also be easier to integrate into the edge distance antialiasing shader.
Comment 1 Martin Robinson 2012-06-17 22:27:18 PDT
Created attachment 148053 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-17 22:44:54 PDT
Comment on attachment 148053 [details]
Patch

Rejecting attachment 148053 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 to file Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp.rej
patching file Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.h
Hunk #1 FAILED at 52.
Hunk #2 FAILED at 71.
2 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Noam Rosen..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12970589
Comment 3 WebKit Review Bot 2012-06-18 10:24:11 PDT
Comment on attachment 148053 [details]
Patch

Clearing flags on attachment: 148053

Committed r120608: <http://trac.webkit.org/changeset/120608>
Comment 4 WebKit Review Bot 2012-06-18 10:24:17 PDT
All reviewed patches have been landed.  Closing bug.