Bug 89307 – Web Inspector: Make text in WebSocket Frames tab selectable

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Nikita Vasilyev]

Cannot copy text form WebSocket Frames tab introduced in https://bugs.webkit.org/show_bug.cgi?id=83282.

[Nikita Vasilyev]

Created attachment 148012 [details]
A fix

[Nikita Vasilyev]

Comment on attachment 148012 [details]
A fix

View in context: https://bugs.webkit.org/attachment.cgi?id=148012&action=review

> Source/WebCore/inspector/front-end/ResourceWebSocketFrameView.js:-26
> -    this.element.addStyleClass("html");

"html" class doesn’t seem to be used.

Should I use classList.add instead of addStyleClass? The latter is just a shortcut for the former but it has the same amount of characters. There is a bug related to it https://bugs.webkit.org/show_bug.cgi?id=72803

[Yury Semikhatsky]

Comment on attachment 148012 [details]
A fix

View in context: https://bugs.webkit.org/attachment.cgi?id=148012&action=review

>> Source/WebCore/inspector/front-end/ResourceWebSocketFrameView.js:-26
>> -    this.element.addStyleClass("html");
> 
> "html" class doesn’t seem to be used.
> 
> Should I use classList.add instead of addStyleClass? The latter is just a shortcut for the former but it has the same amount of characters. There is a bug related to it https://bugs.webkit.org/show_bug.cgi?id=72803

It is OK to use addStyleClass here at the moment for consistency, we will switch the whole file to classList.add at once.

[Nikita Vasilyev]

Is there any reason why the patch still not in commit-queue?

[Pavel Feldman]

(In reply to comment #4)
> Is there any reason why the patch still not in commit-queue?

The reason is that auto-commit was not requested via commit-queue=?

[WebKit Review Bot]

Comment on attachment 148012 [details]
A fix

Clearing flags on attachment: 148012

Committed r120710: <http://trac.webkit.org/changeset/120710>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Nikita Vasilyev]

Pavel, totally forgot it. Thanks!