RESOLVED FIXED 72803
Web Inspector: remove addStyleClass, removeStyleClass and hasStyleClass 
https://bugs.webkit.org/show_bug.cgi?id=72803
Summary Web Inspector: remove addStyleClass, removeStyleClass and hasStyleClass
Timothy Hatcher
Reported 2011-11-19 10:38:47 PST
These functions are just thin wrappers around classList now. We should use classList cirectly instead of these functions.
Attachments
Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2011-11-28 18:36:09 PST
I did TreeOutline in r101313 because I had done it internally on a copy we use in Safari and I upstreamed our changes. We should do the rest of the Inspector next!
Joseph Pecoraro
Comment 2 2011-11-28 18:59:21 PST
There was a comment in: <http://webkit.org/b/55758> Web Inspector: Make use of element.classList in utilities.js > Bug 56096 fixes the first item, and we have agreed with pfeldman that the > add/remove/hasStyleClass improve readability, so the classList methods will > not be inlined. We have reached our primary goal of getting rid of regex-based > operations and the className property modification (which is slow).
Timothy Hatcher
Comment 3 2011-11-28 19:05:09 PST
I think reducing out own wrappers is a good idea, especially if they are so thin as these are. We should also remove Function.prototype.bind, which is native in JSC at least not sure about V8.
Timothy Hatcher
Comment 4 2011-11-28 19:05:36 PST
reducing our own*
Note You need to log in before you can comment on or make changes to this bug.