Bug 72803 - Web Inspector: remove addStyleClass, removeStyleClass and hasStyleClass
Summary: Web Inspector: remove addStyleClass, removeStyleClass and hasStyleClass
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-11-19 10:38 PST by Timothy Hatcher
Modified: 2014-12-13 15:55 PST (History)
10 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2011-11-19 10:38:47 PST
These functions are just thin wrappers around classList now. We should use classList cirectly instead of these functions.
Comment 1 Timothy Hatcher 2011-11-28 18:36:09 PST
I did TreeOutline in r101313 because I had done it internally on a copy we use in Safari and I upstreamed our changes.

We should do the rest of the Inspector next!
Comment 2 Joseph Pecoraro 2011-11-28 18:59:21 PST
There was a comment in:
<http://webkit.org/b/55758> Web Inspector: Make use of element.classList in utilities.js

> Bug 56096 fixes the first item, and we have agreed with pfeldman that the
> add/remove/hasStyleClass improve readability, so the classList methods will
> not be inlined. We have reached our primary goal of getting rid of regex-based
> operations and the className property modification (which is slow).
Comment 3 Timothy Hatcher 2011-11-28 19:05:09 PST
I think reducing out own wrappers is a good idea, especially if they are so thin as these are.

We should also remove Function.prototype.bind, which is native in JSC at least not sure about V8.
Comment 4 Timothy Hatcher 2011-11-28 19:05:36 PST
reducing our own*