Bug 56096 – Web Inspector: Get rid of has/add/removeStyleClass() methods on Element.prototype - Step 1

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

According to the scheme in bug 55758, this step makes use of element.classList methods in utilities.js and narrows down the class addition to single classes per element.addStyleClass() invocation

[Alexander Pavlov (apavlov)]

Created attachment 85317 [details]
[PATCH] Suggested solution

[Yury Semikhatsky]

Comment on attachment 85317 [details]
[PATCH] Suggested solution

View in context: https://bugs.webkit.org/attachment.cgi?id=85317&action=review

Looks like there are several places to fix:

$ grep \.addStyleClass\(\"[^\"]\\+\ [^\"]\\+\" Source/WebCore/inspector/front-end/*
Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:    this.categoriesElement.addStyleClass("properties-tree event-listener-breakpoints");
Source/WebCore/inspector/front-end/DetailedHeapshotView.js:    retainmentView.element.addStyleClass("view retaining-paths-view");
Source/WebCore/inspector/front-end/ResourcesPanel.js:    this.sidebarElement.addStyleClass("outline-disclosure filter-all children small");

> Source/WebCore/inspector/front-end/ResourcesPanel.js:789
> +            var classes = this._iconClass.split(" ");

I'd rather fix callers.

> Source/WebCore/inspector/front-end/SidebarTreeElement.js:183
> +            var classNames = this.className.split(" ");

I'd rather fix callers.

[Alexander Pavlov (apavlov)]

Created attachment 85340 [details]
[PATCH] Comments addressed

[Alexander Pavlov (apavlov)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       Source/WebCore/ChangeLog
        M       Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js
        M       Source/WebCore/inspector/front-end/DetailedHeapshotView.js
        M       Source/WebCore/inspector/front-end/ResourcesPanel.js
        M       Source/WebCore/inspector/front-end/utilities.js
Committed r80831