Bug 89218 - Merge and refactor Widget::setCursor
Summary: Merge and refactor Widget::setCursor
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-15 08:44 PDT by Ryuan Choi
Modified: 2012-10-10 16:31 PDT (History)
6 users (show)

See Also:

Attachments
prototype (19.02 KB, patch)
2012-06-15 09:07 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
prototype(fix warning) (19.50 KB, patch)
2012-06-15 09:17 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
prototype(fix more) (21.33 KB, patch)
2012-06-15 09:38 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
prototype(fix more) (21.03 KB, patch)
2012-06-15 09:52 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
prototype(fix more) (21.32 KB, patch)
2012-06-15 14:50 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2012-06-15 08:44:06 PDT 
I am not sure whether my code reading is wrong.
So, please let me know to close this bug if I am wrong.

While implementing cursor of WebKit2/Efl, I got below assumption.

1. Widget::setCursor is similar. It just passed to chromeclient.
  - efl port was totally different, but now it is same as other ports after Bug 88803 is landed.
  - win port have an addition check, qt port have macro. but others are same.

2. Only EventHandler calls setCursor in WebCore.
  - some ports call it, but I think that they have a way to call ChromeClient::setCursor.

3. setCursor is called although cursor is not changed.
  - for example, every mouse move event will generate IPC message to change cursor in case of WebKit2 (although it is same).

My prototype looks working in efl port and gtk port.
But I don't know how to test cursor (Is it possible?) and I am worried about any regressions.
Comment 1 Ryuan Choi 2012-06-15 09:07:28 PDT 
Created attachment 147832 [details]
prototype
Comment 2 Early Warning System Bot 2012-06-15 09:17:04 PDT 
Comment on attachment 147832 [details]
prototype

Attachment 147832 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12961613
Comment 3 Ryuan Choi 2012-06-15 09:17:40 PDT 
Created attachment 147834 [details]
prototype(fix warning)
Comment 4 Ryuan Choi 2012-06-15 09:38:58 PDT 
Created attachment 147838 [details]
prototype(fix more)
Comment 5 Ryuan Choi 2012-06-15 09:52:15 PDT 
Created attachment 147840 [details]
prototype(fix more)
Comment 6 Build Bot 2012-06-15 10:17:35 PDT 
Comment on attachment 147840 [details]
prototype(fix more)

Attachment 147840 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12964569
Comment 7 Ryuan Choi 2012-06-15 14:50:37 PDT 
Created attachment 147903 [details]
prototype(fix more)