Because WebProcess can not control cursor, setCursor should be passed to UIProcess via ChromeClient. As a second step, Move and refactor cursor related code from WidgetEfl to ewk_view and EflScreenUtilities.
Created attachment 146916 [details] Patch
Created attachment 146921 [details] Patch
Created attachment 146957 [details] Patch
Comment on attachment 146957 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146957&action=review Are there test cases covered by this patch ? > Source/WebCore/platform/efl/EflScreenUtilities.cpp:115 > + Ecore_X_Window win = ecore_evas_software_x11_window_get(ecoreEvas); I prefer to use full name for variable. s/win/window/g, s/cur/cursor/g
Created attachment 147223 [details] Patch
(In reply to comment #4) > (From update of attachment 146957 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=146957&action=review > > Are there test cases covered by this patch ? > I am not sure whether we can test cursor. At least DRT/Efl can not test it because we just calls WebCore::paint. > > Source/WebCore/platform/efl/EflScreenUtilities.cpp:115 > > + Ecore_X_Window win = ecore_evas_software_x11_window_get(ecoreEvas); > > I prefer to use full name for variable. s/win/window/g, s/cur/cursor/g OK, I fixed.
Comment on attachment 147223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147223&action=review From the viewpoint of refactoring, looks fine except for trivial nit. > Source/WebCore/platform/efl/EflScreenUtilities.cpp:134 > + const char *engine = ecore_evas_engine_name_get(ecoreEvas); Style nit : Move '*' to variable side.
Created attachment 147275 [details] Patch
(In reply to comment #7) > (From update of attachment 147223 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=147223&action=review > > From the viewpoint of refactoring, looks fine except for trivial nit. > > > Source/WebCore/platform/efl/EflScreenUtilities.cpp:134 > > + const char *engine = ecore_evas_engine_name_get(ecoreEvas); > > Style nit : Move '*' to variable side. Thanks, fixed.
LGTM.
Comment on attachment 147275 [details] Patch r+ based on Gyuyoung's comments.
Comment on attachment 147275 [details] Patch thank you.
Comment on attachment 147275 [details] Patch Clearing flags on attachment: 147275 Committed r120369: <http://trac.webkit.org/changeset/120369>
All reviewed patches have been landed. Closing bug.