Because WebProcess can not control cursor, setCursor should be passed to UIProcess via ChromeClient. As a first step, Ecore_X_Cursor should be moved out of Widget to call it in WebKit/efl and WebKit2/efl.
Created attachment 146519 [details] Patch
(In reply to comment #0) > Because WebProcess can not control cursor, > setCursor should be passed to UIProcess via ChromeClient. > > As a first step, > Ecore_X_Cursor should be moved out of Widget to call it in WebKit/efl and WebKit2/efl. s/Ecore_X_Cursor/CursorMap I will move Ecore_X_Cursor and other cursor related implementations as next steps.
Comment on attachment 146519 [details] Patch LGTM.
Comment on attachment 146519 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146519&action=review > Source/WebCore/ChangeLog:9 > + Extract it and expose getEcoreCursor. s/Extract/extract/g > Source/WebCore/ChangeLog:11 > + No new tests; refactoring only. s/;/,/g > Source/WebCore/platform/efl/EflScreenUtilities.cpp:52 > + m_cursorStringMap.set("cursor/pointer", ECORE_X_CURSOR_LEFT_PTR); I think it is better to list these cursor map up by alphabetical order. > Source/WebCore/platform/efl/WidgetEfl.cpp:-43 > - Do not remove code unrelated to this patch.
Created attachment 146773 [details] Patch
(In reply to comment #4) > (From update of attachment 146519 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=146519&action=review > > > Source/WebCore/ChangeLog:9 > > + Extract it and expose getEcoreCursor. > > s/Extract/extract/g Done. > > > Source/WebCore/ChangeLog:11 > > + No new tests; refactoring only. > > s/;/,/g Done. > > > Source/WebCore/platform/efl/EflScreenUtilities.cpp:52 > > + m_cursorStringMap.set("cursor/pointer", ECORE_X_CURSOR_LEFT_PTR); > > I think it is better to list these cursor map up by alphabetical order. It is ordered to match with Cursor::Type in Source/WebCore/platform/Cursor.h. IMHO, keeping current order is easier to detect any changes of cursor. > > > Source/WebCore/platform/efl/WidgetEfl.cpp:-43 > > - > > Do not remove code unrelated to this patch. Done.
Ok, Looks good to me now.
Comment on attachment 146773 [details] Patch Clearing flags on attachment: 146773 Committed r119958: <http://trac.webkit.org/changeset/119958>
All reviewed patches have been landed. Closing bug.