Bug 89199 – [GTK][Mac WK2] New editing/spelling/grammar-edit-word.html fails

• Status: NEW
• Component: Tools / Tests

[Szilard Ledan]

The new editing/spelling/grammar-edit-word.html test fails on Qt and GTK since r120423 (http://trac.webkit.org/changeset/120423).

--- /ramdisk/qt-linux-64-release/build/layout-test-results/editing/spelling/grammar-edit-word-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/editing/spelling/grammar-edit-word-actual.txt 
@@ -4,7 +4,7 @@
 
 
 document.execCommand("InsertText", false, "You has the right.")
-PASS internals.hasGrammarMarker(document, 4, 3) is true
+FAIL internals.hasGrammarMarker(document, 4, 3) should be true. Was false.
 Delete the end of this sentence until it becomes "You ha".
 layoutTestController.execCommand("DeleteBackward")
 layoutTestController.execCommand("DeleteBackward")

[Csaba Osztrogonác]

It fails on GTK too ...

[Szilard Ledan]

I skipped it on Qt ( http://trac.webkit.org/changeset/120445/trunk/LayoutTests/platform/qt/Skipped ).

Please unskip it with the proper fix.

[Martin Robinson]

*** Bug 89205 has been marked as a duplicate of this bug. ***

[Hironori Bono]

Greetings,

Apologies for these test failures. (I thought these bots skip all tests in "editing/spelling" because my change finishes without errors on EWS bots.) Unfortunately, this test needs a grammar checker and it fails on Qt and GTK, which does not implement TextChecker::checkGrammarOfString(). Even though I have implemented the MockGrammarChecker class for Chromium DumpRenerTree, I do not have good ideas about how to implement it for Qt or GTK.

(*1) http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Tools/DumpRenderTree/chromium/MockGrammarCheck.cpp

Regards,

Hironori Bono

[Philippe Normand]

There seems to be a wide assumption that all EWS bots run the tests :( To this date though, only the Chromium EWS actually runs them.

[Radar WebKit Bug Importer]

<rdar://problem/11730104>