Bug 88982 – Add ForceScheduler to build.webkit.org

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

Patch is coming soon.

[Csaba Osztrogonác]

Created attachment 147301 [details]
Patch

[Csaba Osztrogonác]

Comment on attachment 147301 [details]
Patch

Unfortunately we can't add it to config.json to the list of schedulers, 
because we have to call FixedParameter, StringParameter, re.compile ...

[Peter Gal]

View in context: https://bugs.webkit.org/attachment.cgi?id=147301&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:7
> +from buildbot.schedulers.forcesched import *

We should explicitly specify which classes are imported.

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:831
> +        name = "force",
> +        builderNames = [ builder['name'] for builder in config['builders'] ],

Remove the spaces from/before the = sign, and in the list comprehension also.

[Peter Gal]

View in context: https://bugs.webkit.org/attachment.cgi?id=147301&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:829
> +    forceScheduler = ForceScheduler (

No need for the space before the '('.

[Csaba Osztrogonác]

Created attachment 147314 [details]
Patch

Suggested things fixed

[Lucas Forschler]

Comment on attachment 147314 [details]
Patch

# Disable default enabled input fields: branch, repository, projecy, additional properties
typo here                                                                           ^^^^^^

[Lucas Forschler]

arg, that formatting didn't work.  
project is mistyped as projecy

[Csaba Osztrogonác]

Created attachment 147631 [details]
Patch

typo fixed

[Lucas Forschler]

Comment on attachment 147631 [details]
Patch

I'm not familiar with the new forceScheduler code which was added in buildbot 0.8.6.  This looks ok to me, but we should probably get a second review.

[Csaba Osztrogonác]

second r?

[Csaba Osztrogonác]

Comment on attachment 147631 [details]
Patch

cq-, because I'm going to test it again and land in an idle time.

[Csaba Osztrogonác]

Comment on attachment 147631 [details]
Patch

Clearing flags on attachment: 147631

Committed r120443: <http://trac.webkit.org/changeset/120443>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

Now it dosn't work, because builder.html was broken (it based on older buildbot). I fixed it - http://trac.webkit.org/changeset/120452 .

But it seems master didn't restarted automatically after this commit for some reason. Lucas, could you restart it manually, please? (And update the builder.html template if the master didn't do it itself?) Thanks in advance.

[Lucas Forschler]

I manually ran svn update on builder.html.