Bug 88981 - Unhide login form on the build.webkit.org
Summary: Unhide login form on the build.webkit.org
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 88982
  Show dependency tree / graph
 
Reported: 2012-06-13 03:31 PDT by Csaba Osztrogonác
Modified: 2012-06-14 13:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.26 KB, patch)
2012-06-13 03:41 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Patch (1.33 KB, patch)
2012-06-13 08:03 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Patch (17.38 KB, patch)
2012-06-14 12:29 PDT, Csaba Osztrogonác 		lforschler: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-06-13 03:31:52 PDT 
It is hidden now with the header. After unhide it,
we can stop builds and cancel pending builds.
(And force builds after adding ForceScheduler)

Patch is coming soon.
Comment 1 Csaba Osztrogonác 2012-06-13 03:41:11 PDT 
Created attachment 147280 [details]
Patch
Comment 2 Csaba Osztrogonác 2012-06-13 03:46:14 PDT 
Comment on attachment 147280 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147280&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:-1
> -div.header { display: none; }

Unhide the header to unhide the login form.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:18
> +.auth (
> +position:absolute;
> +top:5px;
> +right:40px;
> +)
> +

Copied from buildbot-0.8.6p1/buildbot/status/web/files/default.css
to dock login form to the top-left side of the windows.
Comment 3 Peter Gal 2012-06-13 07:30:41 PDT 
View in context: https://bugs.webkit.org/attachment.cgi?id=147280&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:17
> +.auth (
> +position:absolute;
> +top:5px;
> +right:40px;
> +)

I think you wanted to use curly brackets and indentation like everywhere else.
Comment 4 Csaba Osztrogonác 2012-06-13 07:52:29 PDT 
(In reply to comment #3)
> View in context: https://bugs.webkit.org/attachment.cgi?id=147280&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:17
> > +.auth (
> > +position:absolute;
> > +top:5px;
> > +right:40px;
> > +)
> 
> I think you wanted to use curly brackets and indentation like everywhere else.

As I said it was copy/paste code from buildbot. So you found this bug in buildbot. :))
Comment 5 Csaba Osztrogonác 2012-06-13 08:03:25 PDT 
Created attachment 147316 [details]
Patch

CSS bug fixed
Comment 6 WebKit Review Bot 2012-06-13 08:09:42 PDT 
Attachment 147316 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/BuildSlaveSupport/build.webkit.org-c..." exit_code: 1
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:14:  Line contains tab character.  [whitespace/tab] [5]
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:15:  Line contains tab character.  [whitespace/tab] [5]
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:16:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Lucas Forschler 2012-06-14 12:20:43 PDT 
R+ after Tabs are removed and style check passes.
Comment 8 Csaba Osztrogonác 2012-06-14 12:29:39 PDT 
Created attachment 147630 [details]
Patch

fixed patch + style fix (s/TAB/4 spaces/g)
Comment 9 Build Bot 2012-06-14 12:47:17 PDT 
Comment on attachment 147630 [details]
Patch

Attachment 147630 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12964270
Comment 10 Csaba Osztrogonác 2012-06-14 13:03:32 PDT 
Landed in http://trac.webkit.org/changeset/120351