1) Remove "messageLoop" term 2) Reuse WebThread::TaskObserver interface 3) Move implementation (from embedder) to platform code.
Created attachment 147268 [details] Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Created attachment 147278 [details] The sum of changes: new methods/dependencies are marked green
Created attachment 147282 [details] The sum of changes: new methods/dependencies are marked green
Comment on attachment 147268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147268&action=review Thanks!!! > Source/WebKit/chromium/src/WebDevToolsAgentImpl.h:119 > + nit: extra new line here
Comment on attachment 147268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147268&action=review >> Source/WebKit/chromium/src/WebDevToolsAgentImpl.h:119 >> + > > nit: extra new line here fixed
Created attachment 147485 [details] Patch
Comment on attachment 147485 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147485&action=review > Source/WebKit/chromium/src/WebDevToolsAgentImpl.h:105 > + virtual void startCurrentThreadMonitoring(); I would call this "startMainThreadMonitoring". We know that it is called on the main thread and that currentThread below returns what we need. But we don't want clients to think that it is possible to instrument other threads.
Comment on attachment 147485 [details] Patch (please apply the rename and we can land this).
Comment on attachment 147485 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147485&action=review >> Source/WebKit/chromium/src/WebDevToolsAgentImpl.h:105 >> + virtual void startCurrentThreadMonitoring(); > > I would call this "startMainThreadMonitoring". We know that it is called on the main thread and that currentThread below returns what we need. But we don't want clients to think that it is possible to instrument other threads. done
Created attachment 147540 [details] Patch
Comment on attachment 147540 [details] Patch Clearing flags on attachment: 147540 Committed r120318: <http://trac.webkit.org/changeset/120318>
All reviewed patches have been landed. Closing bug.
Comment on attachment 147540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147540&action=review > Source/WebKit/chromium/public/WebDevToolsAgentClient.h:63 > + virtual void startMainThreadMonitoring() { } These methods are never called, please remove them.
(In reply to comment #14) > (From update of attachment 147540 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=147540&action=review > > > Source/WebKit/chromium/public/WebDevToolsAgentClient.h:63 > > + virtual void startMainThreadMonitoring() { } > > These methods are never called, please remove them. Of course. Please see:\ https://bugs.webkit.org/show_bug.cgi?id=89361