WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
88933
[Qt][Wk2] Support client time picker dialog
https://bugs.webkit.org/show_bug.cgi?id=88933
Summary
[Qt][Wk2] Support client time picker dialog
Dinu Jacob
Reported
2012-06-12 16:16:58 PDT
Add support for client time picker dialog for input element 'time'
Attachments
First patch
(19.30 KB, patch)
2012-06-12 16:25 PDT
,
Dinu Jacob
no flags
Details
Formatted Diff
Diff
Patch
(19.23 KB, patch)
2012-06-13 15:29 PDT
,
Dinu Jacob
no flags
Details
Formatted Diff
Diff
Patch with style fix
(19.23 KB, patch)
2012-06-13 17:58 PDT
,
Dinu Jacob
no flags
Details
Formatted Diff
Diff
Style fix
(19.27 KB, patch)
2012-06-13 18:06 PDT
,
Dinu Jacob
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Dinu Jacob
Comment 1
2012-06-12 16:25:08 PDT
Created
attachment 147187
[details]
First patch
Dinu Jacob
Comment 2
2012-06-13 15:29:38 PDT
Created
attachment 147426
[details]
Patch
WebKit Review Bot
Comment 3
2012-06-13 17:00:46 PDT
Attachment 147426
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1 Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.h:26: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.h:27: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.h:53: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.cpp:22: You should add a blank line after implementation file's own header. [build/include_order] [4] Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.cpp:24: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.cpp:26: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.cpp:119: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 7 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dinu Jacob
Comment 4
2012-06-13 17:58:47 PDT
Created
attachment 147453
[details]
Patch with style fix
WebKit Review Bot
Comment 5
2012-06-13 18:02:27 PDT
Attachment 147453
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1 Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.h:26: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.h:27: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.h:53: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.cpp:22: You should add a blank line after implementation file's own header. [build/include_order] [4] Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.cpp:24: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.cpp:26: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.cpp:119: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 7 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dinu Jacob
Comment 6
2012-06-13 18:06:17 PDT
Created
attachment 147456
[details]
Style fix The right patch this time!!
Jocelyn Turcotte
Comment 7
2014-02-03 03:21:12 PST
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at
https://bugreports.qt-project.org
and add a link to this issue. See
http://qt-project.org/wiki/ReportingBugsInQt
for additional guidelines.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug