Bug 88026 - [Wk2] Support input element time
: [Wk2] Support input element time
Status: NEW
Product: WebKit
Classification: Unclassified
Component: WebKit2
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Dinu Jacob
:
Depends on: 86990
Blocks: 88933
  Show dependency treegraph
 
Reported: 2012-05-31 17:05 PDT by Dinu Jacob
Modified: 2016-08-26 02:43 PDT (History)
11 users (show)

See Also:


Attachments
First patch (38.26 KB, patch)
2012-06-12 16:24 PDT, Dinu Jacob
tkent: review-
buildbot: commit‑queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dinu Jacob 2012-05-31 17:05:49 PDT
Add suuport for <input type="time">
Comment 1 Dinu Jacob 2012-06-12 16:24:43 PDT
Created attachment 147186 [details]
First patch
Comment 2 Build Bot 2012-06-12 16:54:34 PDT
Comment on attachment 147186 [details]
First patch

Attachment 147186 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12939855
Comment 3 Kent Tamura 2012-06-13 00:21:37 PDT
(In reply to comment #1)
> Created an attachment (id=147186) [details]
> First patch

What do you think about UI in a page? How does a user invoke TimeChooser?
Comment 4 yosin 2012-06-13 00:25:24 PDT
Please use ENABLE_TIME_CHOOSER for enabling this feature.
Some port, e.g. Android, enables ENABLE_TIME_INPUT but they may not want to use time chooser.
Comment 5 yosin 2012-06-13 00:26:40 PDT
(In reply to comment #4)
> Please use ENABLE_TIME_CHOOSER for enabling this feature.
> Some port, e.g. Android, enables ENABLE_TIME_INPUT but they may not want to use time chooser.

There is an ENABLE_CALENDAR_PICKER used in WebCore/html/DateInputType.cpp
Comment 6 Dinu Jacob 2012-06-13 06:57:43 PDT
I was thinking of modeling it on color chooser implementation (haven't uploaded a patch but have it on my branch). But when I saw the bug that Yosin was working, wanted to wait for that before proceeding with that.
Comment 7 Dinu Jacob 2012-06-13 06:57:58 PDT
(In reply to comment #3)
> (In reply to comment #1)
> > Created an attachment (id=147186) [details] [details]
> > First patch
> 
> What do you think about UI in a page? How does a user invoke TimeChooser?

I was thinking of modeling it on color chooser implementation (haven't uploaded a patch but have it on my branch). But when I saw the bug that Yosin was working, wanted to wait for that before proceeding with that.
Comment 8 Dinu Jacob 2012-06-13 17:00:24 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > Please use ENABLE_TIME_CHOOSER for enabling this feature.
> > Some port, e.g. Android, enables ENABLE_TIME_INPUT but they may not want to use time chooser.
> 
> There is an ENABLE_CALENDAR_PICKER used in WebCore/html/DateInputType.cpp

If I am understanding it correctly, you are suggesting that this feature that delegates the UI to the client in another flag similar to CALENDAR_PICKER?
Comment 9 Dinu Jacob 2012-06-13 18:01:59 PDT
(In reply to comment #8)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > Please use ENABLE_TIME_CHOOSER for enabling this feature.
> > > Some port, e.g. Android, enables ENABLE_TIME_INPUT but they may not want to use time chooser.
> > 
> > There is an ENABLE_CALENDAR_PICKER used in WebCore/html/DateInputType.cpp
> 
> If I am understanding it correctly, you are suggesting that this feature that delegates the UI to the client in another flag similar to CALENDAR_PICKER?

I meant be * be wrapped * in another flag
Comment 10 yosin 2012-06-13 18:14:08 PDT
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #5)
> > > (In reply to comment #4)
> > > > Please use ENABLE_TIME_CHOOSER for enabling this feature.
> > > > Some port, e.g. Android, enables ENABLE_TIME_INPUT but they may not want to use time chooser.
> > > 
> > > There is an ENABLE_CALENDAR_PICKER used in WebCore/html/DateInputType.cpp
> > 
> > If I am understanding it correctly, you are suggesting that this feature that delegates the UI to the client in another flag similar to CALENDAR_PICKER?
> 
> I meant be * be wrapped * in another flag

Yes, please use another flag something like ENABLE_TIME_PICKER, or another appropriate one.
Comment 11 Kent Tamura 2012-06-13 21:11:10 PDT
For desktop browsers, inline editing UI which yosin is working on is enough and picker dialog UI would be unnecessary (or optional).  On the other hand, we want picker dialog UI for mobile browsers, and no inline editing UI.  iOS and Chromium/Android have picker dialog UI for date/time types.
So, both of inline editing UI and picker dialog UI should have their own ENABLE flags.

I think we can make generic API of picker dialog UI for all of date/time types.

We currently have PAGE_POPUP API in ChromeClient for CALENDAR_PICKER, however we might able to change CALENDAR_PICKER so that it uses the generic API and PAGE_POPUP API is one of implementations of the generic API.
Comment 12 Kent Tamura 2012-11-09 00:29:46 PST
Comment on attachment 147186 [details]
First patch

Please apply
 * ENABLE_INPUT_MULTIPLE_FIELDS_UI or 
 * No ENABLE_INPUT_MULTIPLE_FIELDS, and support ChromeClient::openDateTimeChooser