Bug 88897 – Disable autoplay when user gesture is required for media playback

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Min Qin]

Disable autoplay when user gesture is required for media playback

[Min Qin]

Created attachment 147129 [details]
Patch

[Min Qin]

Created attachment 147131 [details]
Patch

[Adam Barth]

Comment on attachment 147131 [details]
Patch

Makes sense.

[Eric Carlson]

Comment on attachment 147131 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147131&action=review

> LayoutTests/media/no-autoplay-with-user-gesture-requirement.html:10
> +            function cleanGestureRequirement() {

Nit: a function's opening brace should be on a new line.

[Eric Carlson]

Comment on attachment 147131 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147131&action=review

> LayoutTests/media/no-autoplay-with-user-gesture-requirement.html:31
> +            function canplaythrough()
> +            {
> +                 setTimeout(testPaused, 500);
> +            }

500ms is a *very* long time for a test to hang out waiting for nothing to happen. The 'play' event handler will make the test fail immediately if playback does start, so I think a much shorter timeout should be used here.

[WebKit Review Bot]

Comment on attachment 147131 [details]
Patch

Clearing flags on attachment: 147131

Committed r120112: <http://trac.webkit.org/changeset/120112>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Carlson]

(In reply to comment #7)
> All reviewed patches have been landed.  Closing bug.

Hmm, guess I should have cleared the cq+ flag :-(

@Min, can you please file to do the cleanup work needed?

[Min Qin]

Hi,Eric
I Created patch https://bugs.webkit.org/show_bug.cgi?id=88909 to fix the comments.
Fixed the bracket and reduced the timeout to 100 ms

(In reply to comment #8)
> (In reply to comment #7)
> > All reviewed patches have been landed.  Closing bug.
> 
> Hmm, guess I should have cleared the cq+ flag :-(
> 
> @Min, can you please file to do the cleanup work needed?

[Eric Carlson]

(In reply to comment #9)
> Hi,Eric
> I Created patch https://bugs.webkit.org/show_bug.cgi?id=88909 to fix the comments.
> Fixed the bracket and reduced the timeout to 100 ms
> 
Thank you very much for the quick fix!