Bug 88909 - Address some feedbacks in layout test
Summary: Address some feedbacks in layout test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-12 13:46 PDT by Min Qin
Modified: 2012-06-13 17:41 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.75 KB, patch)
2012-06-12 13:47 PDT, Min Qin 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cq-02 (658.06 KB, application/zip)
2012-06-12 14:23 PDT, WebKit Review Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Min Qin 2012-06-12 13:46:13 PDT 
Address some feedbacks in layout test
Comment 1 Min Qin 2012-06-12 13:47:51 PDT 
Created attachment 147148 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-12 14:23:39 PDT 
Comment on attachment 147148 [details]
Patch

Rejecting attachment 147148 [details] from commit-queue.

New failing tests:
platform/chromium/compositing/filters/background-filter-blur-outsets.html
platform/chromium/compositing/filters/background-filter-blur.html
Full output: http://queues.webkit.org/results/12951055
Comment 3 WebKit Review Bot 2012-06-12 14:23:42 PDT 
Created attachment 147161 [details]
Archive of layout-test-results from ec2-cq-02

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 4 Min Qin 2012-06-12 15:27:12 PDT 
no idea why there are failing tests, seems unrelated to this change
Comment 5 Xianzhu Wang 2012-06-13 16:37:58 PDT 
Comment on attachment 147148 [details]
Patch

Retry CQ because the layout test failure seems unrelated.
Comment 6 WebKit Review Bot 2012-06-13 17:40:56 PDT 
Comment on attachment 147148 [details]
Patch

Clearing flags on attachment: 147148

Committed r120264: <http://trac.webkit.org/changeset/120264>
Comment 7 WebKit Review Bot 2012-06-13 17:41:00 PDT 
All reviewed patches have been landed.  Closing bug.