Bug 88881 - REGRESSION(r120072): It broke !ENABLE(VIDEO) builds
Summary: REGRESSION(r120072): It broke !ENABLE(VIDEO) builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Blocker
Assignee: Silvia Pfeiffer
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 87835
  Show dependency tree / graph
 
Reported: 2012-06-12 09:12 PDT by Csaba Osztrogonác
Modified: 2012-06-12 15:18 PDT (History)
5 users (show)

See Also:

Attachments
patch of hasVerticalAppearance function (1.78 KB, patch)
2012-06-12 10:29 PDT, Silvia Pfeiffer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-06-12 09:12:51 PDT 
../../../../Source/WebCore/html/shadow/SliderThumbElement.cpp: In function 'bool WebCore::hasVerticalAppearance(WebCore::HTMLInputElement*)':
../../../../Source/WebCore/html/shadow/SliderThumbElement.cpp:68: error: 'class WebCore::RenderTheme' has no member named 'usesVerticalVolumeSlider'

Could you check and fix it, please?
Comment 1 Silvia Pfeiffer 2012-06-12 09:27:42 PDT 
My fault - I'm taking this.
Comment 2 Silvia Pfeiffer 2012-06-12 10:29:59 PDT 
Created attachment 147110 [details]
patch of hasVerticalAppearance function
Comment 3 Csaba Osztrogonác 2012-06-12 10:32:29 PDT 
Comment on attachment 147110 [details]
patch of hasVerticalAppearance function

rs=me
Comment 4 Csaba Osztrogonác 2012-06-12 10:53:08 PDT 
Comment on attachment 147110 [details]
patch of hasVerticalAppearance function

Clearing flags on attachment: 147110

Committed r120092: <http://trac.webkit.org/changeset/120092>
Comment 5 Csaba Osztrogonác 2012-06-12 10:53:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Darin Adler 2012-06-12 10:57:53 PDT 
Comment on attachment 147110 [details]
patch of hasVerticalAppearance function

View in context: https://bugs.webkit.org/attachment.cgi?id=147110&action=review

> Source/WebCore/html/shadow/SliderThumbElement.cpp:73
> +#if ENABLE(VIDEO)
>      RenderTheme* sliderTheme = input->renderer()->theme();
>  
>      return sliderStyle->appearance() == SliderVerticalPart
>          || (sliderStyle->appearance() == MediaVolumeSliderPart && sliderTheme->usesVerticalVolumeSlider());
> +#else
> +    return sliderStyle->appearance() == SliderVerticalPart;
> +#endif

It would be better to do this with an if statement so we would be able to share the SliderVerticalPart code.

#if ENABLE(VIDEO)
    if (sliderStyle->appearance() == MediaVolumeSliderPart && input->renderer()->theme()->usesVerticalVolumeSlider())
        return true;
#endif

    return sliderStyle->appearance() == SliderVerticalPart;
Comment 7 Silvia Pfeiffer 2012-06-12 15:18:11 PDT 
Registered bug 88930 for cleanup.