Bug 88881 – REGRESSION(r120072): It broke !ENABLE(VIDEO) builds

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

../../../../Source/WebCore/html/shadow/SliderThumbElement.cpp: In function 'bool WebCore::hasVerticalAppearance(WebCore::HTMLInputElement*)':
../../../../Source/WebCore/html/shadow/SliderThumbElement.cpp:68: error: 'class WebCore::RenderTheme' has no member named 'usesVerticalVolumeSlider'

Could you check and fix it, please?

[Silvia Pfeiffer]

My fault - I'm taking this.

[Silvia Pfeiffer]

Created attachment 147110 [details]
patch of hasVerticalAppearance function

[Csaba Osztrogonác]

Comment on attachment 147110 [details]
patch of hasVerticalAppearance function

rs=me

[Csaba Osztrogonác]

Comment on attachment 147110 [details]
patch of hasVerticalAppearance function

Clearing flags on attachment: 147110

Committed r120092: <http://trac.webkit.org/changeset/120092>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 147110 [details]
patch of hasVerticalAppearance function

View in context: https://bugs.webkit.org/attachment.cgi?id=147110&action=review

> Source/WebCore/html/shadow/SliderThumbElement.cpp:73
> +#if ENABLE(VIDEO)
>      RenderTheme* sliderTheme = input->renderer()->theme();
>  
>      return sliderStyle->appearance() == SliderVerticalPart
>          || (sliderStyle->appearance() == MediaVolumeSliderPart && sliderTheme->usesVerticalVolumeSlider());
> +#else
> +    return sliderStyle->appearance() == SliderVerticalPart;
> +#endif

It would be better to do this with an if statement so we would be able to share the SliderVerticalPart code.

#if ENABLE(VIDEO)
    if (sliderStyle->appearance() == MediaVolumeSliderPart && input->renderer()->theme()->usesVerticalVolumeSlider())
        return true;
#endif

    return sliderStyle->appearance() == SliderVerticalPart;

[Silvia Pfeiffer]

Registered bug 88930 for cleanup.