RESOLVED FIXED 88930
Clean up patch from bug 88881 
https://bugs.webkit.org/show_bug.cgi?id=88930
Summary Clean up patch from bug 88881
Silvia Pfeiffer
Reported 2012-06-12 15:17:45 PDT
Share the SliderVerticalPart code to reduce ifdef size from bug 88881.
Attachments
patch for hasVerticalAppearance function (1.81 KB, patch)
2012-06-12 18:43 PDT, Silvia Pfeiffer 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-01 (711.91 KB, application/zip)
2012-06-12 22:38 PDT, WebKit Review Bot 		no flags
Details
re-checked tests, all worked (1.81 KB, patch)
2012-06-13 04:13 PDT, Silvia Pfeiffer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Silvia Pfeiffer
Comment 1 2012-06-12 18:43:21 PDT
Created attachment 147209 [details] patch for hasVerticalAppearance function
WebKit Review Bot
Comment 2 2012-06-12 22:38:13 PDT
Comment on attachment 147209 [details] patch for hasVerticalAppearance function Attachment 147209 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12948685 New failing tests: platform/chromium/compositing/layout-width-change.html platform/chromium/compositing/render-surface-alpha-blending.html platform/chromium/compositing/tiny-layer-rotated.html platform/chromium/compositing/huge-layer-rotated.html fast/loader/loadInProgress.html platform/chromium/compositing/3d-corners.html platform/chromium/compositing/video-frame-size-change.html platform/chromium/compositing/perpendicular-layer-sorting.html fast/loader/unload-form-post-about-blank.html platform/chromium/compositing/child-layer-3d-sorting.html platform/chromium/compositing/accelerated-drawing/svg-filters.html platform/chromium/compositing/lost-compositor-context-permanently.html media/track/track-cue-rendering-snap-to-lines-not-set.html platform/chromium/compositing/filters/background-filter-blur-outsets.html platform/chromium/compositing/lost-compositor-context-with-video.html platform/chromium/compositing/accelerated-drawing/alpha.html http/tests/xmlhttprequest/zero-length-response.html http/tests/security/script-crossorigin-loads-correctly.html platform/chromium/compositing/webgl-loses-compositor-context.html platform/chromium/compositing/backface-visibility-transformed.html platform/chromium/compositing/lost-compositor-context-with-rendersurface.html platform/chromium/compositing/lost-compositor-context.html platform/chromium/compositing/img-layer-grow.html platform/chromium/compositing/filters/background-filter-blur-off-axis.html platform/chromium/compositing/filters/background-filter-blur.html platform/chromium/compositing/lost-compositor-context-twice.html
WebKit Review Bot
Comment 3 2012-06-12 22:38:17 PDT
Created attachment 147233 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Silvia Pfeiffer
Comment 4 2012-06-13 00:08:51 PDT
(In reply to comment #2) > (From update of attachment 147209 [details]) > Attachment 147209 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/12948685 > > New failing tests: > platform/chromium/compositing/layout-width-change.html > platform/chromium/compositing/render-surface-alpha-blending.html > platform/chromium/compositing/tiny-layer-rotated.html > platform/chromium/compositing/huge-layer-rotated.html > fast/loader/loadInProgress.html > platform/chromium/compositing/3d-corners.html > platform/chromium/compositing/video-frame-size-change.html > platform/chromium/compositing/perpendicular-layer-sorting.html > fast/loader/unload-form-post-about-blank.html > platform/chromium/compositing/child-layer-3d-sorting.html > platform/chromium/compositing/accelerated-drawing/svg-filters.html > platform/chromium/compositing/lost-compositor-context-permanently.html > media/track/track-cue-rendering-snap-to-lines-not-set.html > platform/chromium/compositing/filters/background-filter-blur-outsets.html > platform/chromium/compositing/lost-compositor-context-with-video.html > platform/chromium/compositing/accelerated-drawing/alpha.html > http/tests/xmlhttprequest/zero-length-response.html > http/tests/security/script-crossorigin-loads-correctly.html > platform/chromium/compositing/webgl-loses-compositor-context.html > platform/chromium/compositing/backface-visibility-transformed.html > platform/chromium/compositing/lost-compositor-context-with-rendersurface.html > platform/chromium/compositing/lost-compositor-context.html > platform/chromium/compositing/img-layer-grow.html > platform/chromium/compositing/filters/background-filter-blur-off-axis.html > platform/chromium/compositing/filters/background-filter-blur.html > platform/chromium/compositing/lost-compositor-context-twice.html Pretty sure that none of these tests failed because of my patch. What do I do now? Re-upload?
Silvia Pfeiffer
Comment 5 2012-06-13 04:13:46 PDT
Created attachment 147285 [details] re-checked tests, all worked
WebKit Review Bot
Comment 6 2012-06-13 13:04:27 PDT
Comment on attachment 147285 [details] re-checked tests, all worked Clearing flags on attachment: 147285 Committed r120239: <http://trac.webkit.org/changeset/120239>
WebKit Review Bot
Comment 7 2012-06-13 13:04:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.