Bug 88634 - [EFL] Add accelerated compositing related files and flags to EFL build system.
Summary: [EFL] Add accelerated compositing related files and flags to EFL build system.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 82315 88630
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-08 01:58 PDT by Hyowon Kim
Modified: 2014-03-24 17:45 PDT (History)
7 users (show)

See Also:

Attachments
Patch (8.08 KB, patch)
2012-06-08 02:08 PDT, Hyowon Kim 		gyuyoung.kim: review-
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hyowon Kim 2012-06-08 01:58:12 PDT 
enable accelerated compositing by adding files and flags to cmake files in EFL port.
Comment 1 Hyowon Kim 2012-06-08 02:08:56 PDT 
Created attachment 146513 [details]
Patch
Comment 2 Ryuan Choi 2012-06-08 06:52:48 PDT 
Comment on attachment 146513 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146513&action=review

> Source/WebCore/PlatformEfl.cmake:301
> +  LIST(APPEND WebCore_SOURCES
> +    platform/graphics/efl/GraphicsContext3DEfl.cpp
> +    platform/graphics/efl/GraphicsContext3DPrivate.cpp
> +    platform/graphics/OpenGLShims.cpp
> +    platform/graphics/surfaces/GraphicsSurface.cpp
> +    platform/graphics/texmap/LayerTransform.cpp
> +    platform/graphics/texmap/TextureMapper.cpp
> +    platform/graphics/texmap/TextureMapperGL.cpp
> +    platform/graphics/texmap/TextureMapperAnimation.cpp
> +    platform/graphics/texmap/TextureMapperBackingStore.cpp
> +    platform/graphics/texmap/TextureMapperImageBuffer.cpp
> +    platform/graphics/texmap/TextureMapperShaderManager.cpp
> +    platform/graphics/texmap/GraphicsLayerTextureMapper.cpp
> +    platform/graphics/texmap/TextureMapperLayer.cpp
> +  )

Ordering looks wrong.

> Tools/EWebLauncher/main.c:637
> -    app->ee = ecore_evas_new(engine, 0, 0, geometry.w, geometry.h, NULL);
> +    app->ee = ecore_evas_new("opengl_x11", 0, 0, geometry.w, geometry.h, NULL);

I am not sure.
Should it be mandatory?
Comment 3 Gyuyoung Kim 2012-06-08 07:50:19 PDT 
Comment on attachment 146513 [details]
Patch

Attachment 146513 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12921527
Comment 4 Gyuyoung Kim 2012-06-09 04:22:30 PDT 
Comment on attachment 146513 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146513&action=review

> ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Missing description.

> Source/WTF/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

ditto.

> Source/WebCore/ChangeLog:10
> +        * PlatformEfl.cmake:

ditto.

> Source/cmake/OptionsEfl.cmake:40
> +FIND_PACKAGE(OpenGL REQUIRED)

Move this to line 26 as below,

FIND_PACKAGE(Cairo 1.10 REQUIRED)
FIND_PACKAGE(EFL REQUIRED)
FIND_PACKAGE(Fontconfig 2.8.0 REQUIRED)
+FIND_PACKAGE(OpenGL REQUIRED)
FIND_PACKAGE(Sqlite REQUIRED)
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-06-14 19:24:47 PDT 
Comment on attachment 146513 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146513&action=review

I wonder if forcing 3d acceleration and the Evas OpenGL engine are really required; why not add those WTF defines and require OpenGL only if 3D rendering is on?

> ChangeLog:3
> +        [EFL] Add AC related files and flags to EFL build system.

I'd rather expand the "AC" abbreviation to avoid confusion.