Bug 88584 – REGRESSION(r119744): Fails assertions in debug builds (Requested by jamesr_ on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/119744 broke the build:
Fails assertions in debug builds (Requested by jamesr_ on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[James Robinson]

[ RUN      ] CCLayerTreeHostImplTest.dontUseOldResourcesAfterLostContext
ASSERTION FAILED: extensions->supports("GL_CHROMIUM_iosurface")
third_party/WebKit/Source/WebCore/platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp(73) : virtual void WebCore::CCIOSurfaceLayerImpl::willDraw(WebCore::CCRenderer*, WebCore::CCGraphicsContext*)
1   0x176285a
2   0x178d1e0
3   0x178d77b
4   0x548b3e
5   0xb6fe07
6   0xb6cb14
7   0xb61364
8   0xb61b88
9   0xb6227e
10  0xb67209
11  0xb71007
12  0xb6d515
13  0xb65cf2
14  0xbd9a71
15  0x420c4d
16  0x7f6d589b2c4d __libc_start_main
17  0x420b49
[25959:25959:0607/152544:6571346450322:ERROR:process_util_posix.cc(143)] Received signal 11
	base::debug::StackTrace::StackTrace() [0xba00fa]
	base::(anonymous namespace)::StackDumpSignalHandler() [0xba5295]
	0x7f6d589c7af0
	WebCore::CCIOSurfaceLayerImpl::willDraw() [0x1762864]
	WebCore::CCLayerTreeHostImpl::calculateRenderPasses() [0x178d1e0]
	WebCore::CCLayerTreeHostImpl::prepareToDraw() [0x178d77b]
	(anonymous namespace)::CCLayerTreeHostImplTest_dontUseOldResourcesAfterLostContext_Test::TestBody() [0x548b3e]
	testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0xb6fe07]
	testing::internal::HandleExceptionsInMethodIfSupported<>() [0xb6cb14]
	testing::Test::Run() [0xb61364]
	testing::TestInfo::Run() [0xb61b88]
	testing::TestCase::Run() [0xb6227e]
	testing::internal::UnitTestImpl::RunAllTests() [0xb67209]
	testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0xb71007]
	testing::internal::HandleExceptionsInMethodIfSupported<>() [0xb6d515]
	testing::UnitTest::Run() [0xb65cf2]
	base::TestSuite::Run() [0xbd9a71]
	main [0x420c4d]
	0x7f6d589b2c4d
	0x420b49

[WebKit Review Bot]

Created attachment 146401 [details]
ROLLOUT of r119744

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[James Robinson]

I think perhaps if you want to have a unit test with an io surface layer your context needs to pretend to implement at least some of the extension. I didn't look in great detail, though.

[WebKit Review Bot]

Comment on attachment 146401 [details]
ROLLOUT of r119744

Clearing flags on attachment: 146401

Committed r119762: <http://trac.webkit.org/changeset/119762>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Dana Jansens]

Yeh looks like it, thanks. Will fix as soon as my desktop is working again!