Bug 88371 - [chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed
Summary: [chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on: 88584
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-05 15:45 PDT by Dana Jansens
Modified: 2012-08-22 08:04 PDT (History)
8 users (show)

See Also:


Attachments
Patch (14.15 KB, patch)
2012-06-05 15:49 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff
Patch (8.52 KB, patch)
2012-06-05 15:57 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff
Patch for landing (11.47 KB, patch)
2012-06-08 18:26 PDT, Dana Jansens
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-06-05 15:45:08 PDT
[chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed
Comment 1 Dana Jansens 2012-06-05 15:48:11 PDT
The one thing I wasn't sure about was returning a PassRefPtr<CCGraphicsContext> vs a CCGraphicsContext*. The latter requires storing a CCGraphicsContext permanently in LRC which maybe we want to do?
Comment 2 Dana Jansens 2012-06-05 15:49:13 PDT
Created attachment 145884 [details]
Patch
Comment 3 Alexandre Elias 2012-06-05 15:51:59 PDT
The CCLayerTreeHostImpl already holds a CCGraphicsContext, so how about using that one instead of adding the method to CCRenderer?
Comment 4 Dana Jansens 2012-06-05 15:52:47 PDT
Ohh, I didn't see that one, thanks.
Comment 5 Dana Jansens 2012-06-05 15:57:06 PDT
Created attachment 145887 [details]
Patch
Comment 6 Dana Jansens 2012-06-05 16:02:01 PDT
Well, I guess it depends if m_frame->planes() > 0. Maybe it's always 0 when a format with external texture is used?
Comment 7 Dana Jansens 2012-06-05 16:02:16 PDT
er.. wrong bug :(
Comment 8 Dana Jansens 2012-06-07 09:54:54 PDT
ping for review :)
Comment 9 James Robinson 2012-06-07 11:43:37 PDT
Comment on attachment 145887 [details]
Patch

R=me
Comment 10 WebKit Review Bot 2012-06-07 12:07:55 PDT
Comment on attachment 145887 [details]
Patch

Clearing flags on attachment: 145887

Committed r119744: <http://trac.webkit.org/changeset/119744>
Comment 11 WebKit Review Bot 2012-06-07 12:08:01 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 WebKit Review Bot 2012-06-07 15:30:45 PDT
Re-opened since this is blocked by 88584
Comment 13 Dana Jansens 2012-06-08 18:26:04 PDT
Created attachment 146676 [details]
Patch for landing
Comment 14 WebKit Review Bot 2012-06-08 22:56:40 PDT
Comment on attachment 146676 [details]
Patch for landing

Rejecting attachment 146676 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
rce/WebCore/platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp
patching file Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp
Hunk #2 succeeded at 1725 (offset 100 lines).
Hunk #3 succeeded at 1791 (offset 100 lines).
Hunk #4 FAILED at 1711.
1 out of 4 hunks FAILED -- saving rejects to file Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12919707
Comment 15 Dana Jansens 2012-08-22 08:04:46 PDT
This was landed again but not closed.