[chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed
The one thing I wasn't sure about was returning a PassRefPtr<CCGraphicsContext> vs a CCGraphicsContext*. The latter requires storing a CCGraphicsContext permanently in LRC which maybe we want to do?
Created attachment 145884 [details] Patch
The CCLayerTreeHostImpl already holds a CCGraphicsContext, so how about using that one instead of adding the method to CCRenderer?
Ohh, I didn't see that one, thanks.
Created attachment 145887 [details] Patch
Well, I guess it depends if m_frame->planes() > 0. Maybe it's always 0 when a format with external texture is used?
er.. wrong bug :(
ping for review :)
Comment on attachment 145887 [details] Patch R=me
Comment on attachment 145887 [details] Patch Clearing flags on attachment: 145887 Committed r119744: <http://trac.webkit.org/changeset/119744>
All reviewed patches have been landed. Closing bug.
Re-opened since this is blocked by 88584
Created attachment 146676 [details] Patch for landing
Comment on attachment 146676 [details] Patch for landing Rejecting attachment 146676 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: rce/WebCore/platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp patching file Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp Hunk #2 succeeded at 1725 (offset 100 lines). Hunk #3 succeeded at 1791 (offset 100 lines). Hunk #4 FAILED at 1711. 1 out of 4 hunks FAILED -- saving rejects to file Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12919707
This was landed again but not closed.