WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
88489
[Forms] Improve test coverage of input-number-size.html
https://bugs.webkit.org/show_bug.cgi?id=88489
Summary
[Forms] Improve test coverage of input-number-size.html
yosin
Reported
2012-06-06 20:44:42 PDT
When we introduce decimal arithmetic, we change NumberInputType::sizeShouldIncludeDecoration(). To make sure that change doesn't change behavior, we would like to improve test coverage for sizeShouldIncludeDecoration(). This bug suggests to add following test case to /forms/number/input-number-size.html shouldBe('numberWidth(123456, 123456, 0.0000005)', 'textWidthPlusSpinButtonWidth(14)');
Attachments
Patch 1
(2.28 KB, patch)
2012-06-06 20:52 PDT
,
yosin
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
yosin
Comment 1
2012-06-06 20:52:43 PDT
Created
attachment 146185
[details]
Patch 1
yosin
Comment 2
2012-06-06 20:53:14 PDT
Comment on
attachment 146185
[details]
Patch 1 Could you review this patch? Thanks in advance.
Kent Tamura
Comment 3
2012-06-06 21:11:30 PDT
Comment on
attachment 146185
[details]
Patch 1 ok
WebKit Review Bot
Comment 4
2012-06-07 02:47:41 PDT
Comment on
attachment 146185
[details]
Patch 1 Clearing flags on attachment: 146185 Committed
r119699
: <
http://trac.webkit.org/changeset/119699
>
WebKit Review Bot
Comment 5
2012-06-07 02:47:46 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug