Bug 88489 - [Forms] Improve test coverage of input-number-size.html
Summary: [Forms] Improve test coverage of input-number-size.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 88383
  Show dependency treegraph
 
Reported: 2012-06-06 20:44 PDT by yosin
Modified: 2012-06-07 02:47 PDT (History)
2 users (show)

See Also:


Attachments
Patch 1 (2.28 KB, patch)
2012-06-06 20:52 PDT, yosin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-06-06 20:44:42 PDT
When we introduce decimal arithmetic, we change NumberInputType::sizeShouldIncludeDecoration().
To make sure that change doesn't change behavior, we would like to improve test coverage for sizeShouldIncludeDecoration().

This bug suggests to add following test case to /forms/number/input-number-size.html
  shouldBe('numberWidth(123456, 123456, 0.0000005)', 'textWidthPlusSpinButtonWidth(14)');
Comment 1 yosin 2012-06-06 20:52:43 PDT
Created attachment 146185 [details]
Patch 1
Comment 2 yosin 2012-06-06 20:53:14 PDT
Comment on attachment 146185 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 Kent Tamura 2012-06-06 21:11:30 PDT
Comment on attachment 146185 [details]
Patch 1

ok
Comment 4 WebKit Review Bot 2012-06-07 02:47:41 PDT
Comment on attachment 146185 [details]
Patch 1

Clearing flags on attachment: 146185

Committed r119699: <http://trac.webkit.org/changeset/119699>
Comment 5 WebKit Review Bot 2012-06-07 02:47:46 PDT
All reviewed patches have been landed.  Closing bug.