Bug 88480 - [Platform] Introduce conversion from/to Deciaml to/from double
Summary: [Platform] Introduce conversion from/to Deciaml to/from double
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 88383
  Show dependency treegraph
 
Reported: 2012-06-06 18:42 PDT by yosin
Modified: 2012-06-07 00:57 PDT (History)
2 users (show)

See Also:


Attachments
Build verification (12.70 KB, patch)
2012-06-06 19:33 PDT, yosin
no flags Details | Formatted Diff | Diff
Patch 2 (11.34 KB, patch)
2012-06-06 20:39 PDT, yosin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-06-06 18:42:25 PDT
To reduce size of patch of bug 88383, we introduce following functions:
 * Decimal Decimal::fromDouble(double) -- this is implementation of convertDoubleToInputNumber
 * double Decimal::toDouble() const -- this is implementation of convertInputNumberToDouble
 * bool isfinite(const Decimal&)
 * bool isinf(const Decimal&)
 * bool isnan(const Decimal&)
Comment 1 yosin 2012-06-06 19:33:21 PDT
Created attachment 146179 [details]
Build verification
Comment 2 Build Bot 2012-06-06 19:39:46 PDT
Comment on attachment 146179 [details]
Build verification

Attachment 146179 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12919024
Comment 3 yosin 2012-06-06 20:22:58 PDT
Since some platforms define isfinite/isinf/isnan as macro. We can't define overload version for them. :<
Comment 4 yosin 2012-06-06 20:39:58 PDT
Created attachment 146183 [details]
Patch 2
Comment 5 yosin 2012-06-06 21:09:54 PDT
Comment on attachment 146183 [details]
Patch 2

Could you review this patch?
Thanks in advance.

* It seems win-ews is stuck.
Comment 6 Kent Tamura 2012-06-06 21:21:11 PDT
Comment on attachment 146183 [details]
Patch 2

ok
Comment 7 WebKit Review Bot 2012-06-07 00:57:15 PDT
Comment on attachment 146183 [details]
Patch 2

Clearing flags on attachment: 146183

Committed r119692: <http://trac.webkit.org/changeset/119692>
Comment 8 WebKit Review Bot 2012-06-07 00:57:20 PDT
All reviewed patches have been landed.  Closing bug.