It seems like it's safe to remove the old test_shell code from the desktop chromium ports, as the webkit/drt output has run happily from some time. However, it looks like the android port might still be using the old style interface? I'm not quite sure since I don't know what the state of the upstreaming is and if/how they specify the --test-shell command line anywhere to trigger the old behavior. Can someone more familiar with the Android port confirm that we can either delete that code outright and just have ChromiumAndroidDriver subclass WebKitDriver, or merge all of the ChromiumDriver code into ChromiumAndroidDriver?
The chromium-android port does appear to be using --test-shell. I'm not sure what's involved in making it work without that flag.
there's no real urgency on this change, but it might be nice to at least move the class over to reduce any potential confusion on the desktop side.
*** Bug 86928 has been marked as a duplicate of this bug. ***
resetting the owner in case someone else wants to take a look, as these bugs aren't on my immediate to-do list.
I'll do this after finishing bug 88542. Dirk, could you review the patch of bug 88542?
(In reply to comment #5) > I'll do this after finishing bug 88542. > > Dirk, could you review the patch of bug 88542? Sure, posted comments there.
Created attachment 152667 [details] Patch
Comment on attachment 152667 [details] Patch yay!
Comment on attachment 152667 [details] Patch Clearing flags on attachment: 152667 Committed r122855: <http://trac.webkit.org/changeset/122855>
All reviewed patches have been landed. Closing bug.
@jochen: This is the patch I mentioned that removes support for test shell mode.
Is there code in DumpRenderTree to delete now too?
(In reply to comment #12) > Is there code in DumpRenderTree to delete now too? That's in bug 86927.