Bug 86927 - [chromium] remove --test-shell support from DRT
Summary: [chromium] remove --test-shell support from DRT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xianzhu Wang
URL:
Keywords:
Depends on: 88542
Blocks: 91532
  Show dependency tree / graph
 
Reported: 2012-05-18 17:22 PDT by Dirk Pranke
Modified: 2012-07-17 22:31 PDT (History)
9 users (show)

See Also:

Attachments
Patch (16.30 KB, patch)
2012-07-17 10:45 PDT, Xianzhu Wang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-05-18 17:22:40 PDT 
We no longer need it.
Comment 1 Xianzhu Wang 2012-07-13 11:03:23 PDT 
I'll do this after finish bug 85542.
Comment 2 Xianzhu Wang 2012-07-13 11:04:12 PDT 
Sorry, should be bug 88542.
Comment 3 Xianzhu Wang 2012-07-17 10:45:29 PDT 
Created attachment 152782 [details]
Patch
Comment 4 WebKit Review Bot 2012-07-17 12:02:11 PDT 
Comment on attachment 152782 [details]
Patch

Clearing flags on attachment: 152782

Committed r122866: <http://trac.webkit.org/changeset/122866>
Comment 5 WebKit Review Bot 2012-07-17 12:02:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Matt Falkenhagen 2012-07-17 20:42:41 PDT 
The extension API documentation build script in Chrome, chrome/common/extensions/docs/build/build.py, uses --test-shell. It seems with this change, the script fails. Is there some other option it should be using?

https://code.google.com/p/chromium/issues/detail?id=137798
Comment 7 Dirk Pranke 2012-07-17 22:31:29 PDT 
(In reply to comment #6)
> The extension API documentation build script in Chrome, chrome/common/extensions/docs/build/build.py, uses --test-shell. It seems with this change, the script fails. Is there some other option it should be using?
> 
> https://code.google.com/p/chromium/issues/detail?id=137798

Commented in the chromium bug. Let's discuss this there first.