Bug 88394 - [Form] Changes for InputNumber type
Summary: [Form] Changes for InputNumber type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 88383
  Show dependency treegraph
 
Reported: 2012-06-05 23:51 PDT by yosin
Modified: 2012-06-06 21:05 PDT (History)
2 users (show)

See Also:


Attachments
Patch 1 (7.07 KB, patch)
2012-06-06 00:44 PDT, yosin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-06-05 23:51:48 PDT
On bug 88220, we introduced InputNumber type for reducing patch size of introducing Decimal type. Although, I forgot number of places to use InputNumber.
We should fix this before introducing Decimal type.
Comment 1 yosin 2012-06-06 00:44:31 PDT
Created attachment 145952 [details]
Patch 1
Comment 2 yosin 2012-06-06 00:59:17 PDT
Comment on attachment 145952 [details]
Patch 1

Could you review this patch?
Thanks in advance.

* Local build with enabling all input type on
* To avoid including wtf/MathExtras.h for round in StepRange.h. roundByStep function is defined in StepRange.cpp.
** On Decimal, we don't need to include MathExtras.h to use round.
Comment 3 Kent Tamura 2012-06-06 01:55:56 PDT
Comment on attachment 145952 [details]
Patch 1

ok
Comment 4 WebKit Review Bot 2012-06-06 03:26:36 PDT
Comment on attachment 145952 [details]
Patch 1

Clearing flags on attachment: 145952

Committed r119580: <http://trac.webkit.org/changeset/119580>
Comment 5 WebKit Review Bot 2012-06-06 03:26:40 PDT
All reviewed patches have been landed.  Closing bug.