Bug 88309 – [Qt][Win] Fix const problem in Source/WebCore/xml/parser/XMLDocumentParserQt.cpp

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: Tools / Tests

[Csaba Osztrogonác]

The compiler (MSVC) said that Attribute local variable in ctr in 
Source/WebCore/xml/parser/XMLDocumentParserQt.cpp should be const, 
because const Attribute * -> Attribute * conversion isn't allowed.

[Csaba Osztrogonác]

Created attachment 145785 [details]
Patch

I trust in MSVC. :) Let's see the other bots' opinion ...

[Csaba Osztrogonác]

Ah, the build error which is fixed by the attached patch:

f:\WebKit\Source\WebCore\xml\parser\XMLDocumentParserQt.cpp(143) : error C2440: 'initializing' : cannot convert from 'const WebCore::Attribute *' to 'WebCore::Attribute *'
        Conversion loses qualifiers
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio 10.0\VC\Bi
n\cl.EXE"' : return code '0x2'

[Simon Hausmann]

Comment on attachment 145785 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145785&action=review

> Source/WebCore/xml/parser/XMLDocumentParserQt.cpp:143
> -                Attribute* attr = attrs->attributeItem(i);
> +                const Attribute* attr = attrs->attributeItem(i);

I'm confused. Why does the compiler think the return value of attributeItem() is a const Attribute* given the signature in ElementAttributeData:

    dom/ElementAttributeData.h:    Attribute* attributeItem(unsigned index) const { return &const_cast<ElementAttributeData*>(this)->m_attributes[index]; }

[Csaba Osztrogonác]

I can't see inside the MSVC's soul, so I have no idea ...
But the patch I attached would make it happy. :)

[Csaba Osztrogonác]

ping r?

[Csaba Osztrogonác]

I don't know what changed in WebKit, but it seems it works now without this patch. (I'll reopen if it occurs again.)