WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 88305
[Qt][Win] Use OS(WINDOWS) instead of Q_WS_WIN in WebCore/platform/graphics/GraphicsContext.h
https://bugs.webkit.org/show_bug.cgi?id=88305
Summary
[Qt][Win] Use OS(WINDOWS) instead of Q_WS_WIN in WebCore/platform/graphics/Gr...
Csaba Osztrogonác
Reported
2012-06-05 01:12:26 PDT
... because Q_WS_WIN doesn't exist anymore.
Attachments
Patch
(1.73 KB, patch)
2012-06-05 09:20 PDT
,
Csaba Osztrogonác
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1
2012-06-05 09:20:11 PDT
Created
attachment 145817
[details]
Patch
Simon Hausmann
Comment 2
2012-06-05 14:28:53 PDT
Comment on
attachment 145817
[details]
Patch Although I would prefer if this was landed with OS(WINDOWS) instead of defined(Q_OS_WIN), for consistency within the very same pre-processor line :)
Csaba Osztrogonác
Comment 3
2012-06-07 04:49:33 PDT
(In reply to
comment #2
)
> (From update of
attachment 145817
[details]
) > Although I would prefer if this was landed with OS(WINDOWS) instead of defined(Q_OS_WIN), for consistency within the very same pre-processor line :)
Fixed patch landed in
http://trac.webkit.org/changeset/119706
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug