RESOLVED FIXED 88234
Don't mark main frame layer opaque if the frame view is transparent 
https://bugs.webkit.org/show_bug.cgi?id=88234
Summary Don't mark main frame layer opaque if the frame view is transparent
Arvid Nilsson
Reported 2012-06-04 08:06:46 PDT
In the BlackBerry port, we sometimes use an AC layer to draw the contents of the "root" layer, i.e. the output of the main frame's FrameView::drawContents(). We also use the GraphicsLayer::contentsOpaque() (and other factors) to figure out whether to enable GL blending when compositing that layer. I found some code that sets the main frame renderview's layer opaque (unconditionally) which looks like it could break things when the main frame's FrameView has a transparent background color, because it will cause us to turn off blending for that layer. This should be seen in context of bug #88233.
Attachments
Patch (1.53 KB, patch)
2012-06-04 08:14 PDT, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Arvid Nilsson
Comment 1 2012-06-04 08:07:47 PDT
Change component
Arvid Nilsson
Comment 2 2012-06-04 08:14:26 PDT
Created attachment 145589 [details] Patch
Arvid Nilsson
Comment 3 2012-06-04 08:15:16 PDT
We use void FrameView::updateBackgroundRecursively(const Color&, bool) to set the background color and isTransparent.
Arvid Nilsson
Comment 4 2012-06-04 08:16:08 PDT
Comment on attachment 145589 [details] Patch I'm putting this patch up to get a sanity check from the Mac port and some feedback on whether this is testable on Mac (or any other) platform.
Simon Fraser (smfr)
Comment 5 2012-06-04 08:28:27 PDT
Comment on attachment 145589 [details] Patch I think this is OK.
Arvid Nilsson
Comment 6 2012-06-04 08:39:48 PDT
Comment on attachment 145589 [details] Patch Thanks Simon, I've verified that this fixes the bug on our platform, let's see how it fares in the commit queue...
WebKit Review Bot
Comment 7 2012-06-17 19:28:27 PDT
Comment on attachment 145589 [details] Patch Clearing flags on attachment: 145589 Committed r120561: <http://trac.webkit.org/changeset/120561>
WebKit Review Bot
Comment 8 2012-06-17 19:28:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.