Bug 88233 - [BlackBerry] Allow WebPageCompositor to blend a transparent web page
Summary: [BlackBerry] Allow WebPageCompositor to blend a transparent web page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Arvid Nilsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-04 08:06 PDT by Arvid Nilsson
Modified: 2012-06-07 07:01 PDT (History)
5 users (show)

See Also:


Attachments
Patch (12.97 KB, patch)
2012-06-04 08:31 PDT, Arvid Nilsson
no flags Details | Formatted Diff | Diff
Patch (13.11 KB, patch)
2012-06-04 11:16 PDT, Arvid Nilsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Nilsson 2012-06-04 08:06:32 PDT
Currently, WebPageCompositor always turns off blending when compositing the "root" layer, regardless of whether it's drawn by the BackingStore or by an AC layer.

This is PR159998.
Comment 1 Arvid Nilsson 2012-06-04 08:31:16 PDT
Created attachment 145591 [details]
Patch
Comment 2 Arvid Nilsson 2012-06-04 10:44:48 PDT
I got an internal R+ from Jakob Petsovits, in a comment on the PR
Comment 3 Rob Buis 2012-06-04 10:49:32 PDT
Comment on attachment 145591 [details]
Patch

Looks good.
Comment 4 Arvid Nilsson 2012-06-04 11:16:25 PDT
Created attachment 145608 [details]
Patch

Improved changelog message with PR number and credit to Jakob =)
Comment 5 Rob Buis 2012-06-04 11:23:39 PDT
Comment on attachment 145608 [details]
Patch

Even better :)
Comment 6 WebKit Review Bot 2012-06-07 07:00:57 PDT
Comment on attachment 145608 [details]
Patch

Clearing flags on attachment: 145608

Committed r119718: <http://trac.webkit.org/changeset/119718>
Comment 7 WebKit Review Bot 2012-06-07 07:01:05 PDT
All reviewed patches have been landed.  Closing bug.