Bug 87988 - [Qt] Add a custom Color Chooser widget to MiniBrowser
Summary: [Qt] Add a custom Color Chooser widget to MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on: 87749
Blocks: 87989
  Show dependency tree / graph
 
Reported: 2012-05-31 10:26 PDT by Thiago Marcos P. Santos
Modified: 2012-06-21 06:13 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.59 KB, patch)
2012-05-31 13:01 PDT, Thiago Marcos P. Santos 		no flags Details | Formatted Diff | Diff
Patch v2 (5.67 KB, patch)
2012-06-21 05:32 PDT, Thiago Marcos P. Santos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-05-31 10:26:15 PDT 
For handling input fields type="color.
Comment 1 Thiago Marcos P. Santos 2012-05-31 13:01:42 PDT 
Created attachment 145139 [details]
Patch
Comment 2 Alexis Menard (darktears) 2012-06-21 04:47:04 PDT 
Comment on attachment 145139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145139&action=review

Overall it's ok, the basic color picker is fine for testing :). Could you please fix the style? thanks

> Tools/MiniBrowser/qt/qml/ColorChooser.qml:41
> +        width: parent.width / 4 ; height: parent.height / 4

one statement per line and no ; needed then.

> Tools/MiniBrowser/qt/qml/ColorChooser.qml:46
> +            anchors.left: parent.left; anchors.top: parent.top

same here.

> Tools/MiniBrowser/qt/qml/ColorChooser.qml:48
> +            width: parent.width / 2 - dialog.spacing; height: parent.height / 2 - dialog.spacing

here.

> Tools/MiniBrowser/qt/qml/ColorChooser.qml:60
> +            width: parent.width / 2 - dialog.spacing; height: parent.height / 2 - dialog.spacing

same here

> Tools/MiniBrowser/qt/qml/ColorChooser.qml:70
> +            anchors.bottom: parent.bottom; anchors.left: parent.left

ditto

> Tools/MiniBrowser/qt/qml/ColorChooser.qml:72
> +            width: parent.width / 2 - dialog.spacing; height: parent.height / 2 - dialog.spacing

ditto.

> Tools/MiniBrowser/qt/qml/ColorChooser.qml:82
> +            anchors.bottom: parent.bottom; anchors.right: parent.right

ditto.
Comment 3 Thiago Marcos P. Santos 2012-06-21 05:32:24 PDT 
Created attachment 148773 [details]
Patch v2

Updated patch addressing the comments. Thanks for reviewing.
Comment 4 Alexis Menard (darktears) 2012-06-21 05:36:03 PDT 
Comment on attachment 148773 [details]
Patch v2

LGTM
Comment 5 WebKit Review Bot 2012-06-21 06:13:00 PDT 
Comment on attachment 148773 [details]
Patch v2

Clearing flags on attachment: 148773

Committed r120921: <http://trac.webkit.org/changeset/120921>
Comment 6 WebKit Review Bot 2012-06-21 06:13:07 PDT 
All reviewed patches have been landed.  Closing bug.