Bug 87749 – [WK2][Qt] Color chooser API missing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Thiago Marcos P. Santos]

Show a nice color chooser window for <input type="color">.

[Thiago Marcos P. Santos]

Created attachment 145138 [details]
Patch

[Kenneth Rohde Christiansen]

Looks OK to me, but cc'ing Tor Arne to look at the QML related code.

[Pierre Rossi]

Comment on attachment 145138 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145138&action=review

Nice stuff, thanks !

> Source/WebKit2/Target.pri:801
> +contains(DEFINES, ENABLE_INPUT_TYPE_COLOR=1) {

Maybe we could enable it by default for Qt 5 in Tools/qmake/mkspecs/features/features.prf ?

> Source/WebKit2/UIProcess/qt/WebColorChooserProxyQt.cpp:36
> +    Q_PROPERTY(QColor currentColor READ currentColor CONSTANT FINAL)

Maybe we'd want to expose the elementRect like in WebPopupMenuProxyQt.

[Thiago Marcos P. Santos]

(In reply to comment #3)
> (From update of attachment 145138 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145138&action=review
> 
> Nice stuff, thanks !

Thank you very much for having a look.

> 
> > Source/WebKit2/Target.pri:801
> > +contains(DEFINES, ENABLE_INPUT_TYPE_COLOR=1) {
> 
> Maybe we could enable it by default for Qt 5 in Tools/qmake/mkspecs/features/features.prf ?

Good idea. Gonna ask on the qt webkit list when I get this landed if it is fine to enable by default since IMO, the feature is complete.

> 
> > Source/WebKit2/UIProcess/qt/WebColorChooserProxyQt.cpp:36
> > +    Q_PROPERTY(QColor currentColor READ currentColor CONSTANT FINAL)
> 
> Maybe we'd want to expose the elementRect like in WebPopupMenuProxyQt.

The problem here is, unlike PopupMenu, WebCore doesn't provide the coordinates. :/

[Thiago Marcos P. Santos]

Created attachment 147286 [details]
Patch

Rebased.

[Kenneth Rohde Christiansen]

Comment on attachment 147286 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147286&action=review

Can we have a tesT?

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1158
> +    if (d->colorChooser == colorChooser)
> +        return;

we normally add newline after return

[Thiago Marcos P. Santos]

(In reply to comment #6)
> (From update of attachment 147286 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=147286&action=review
> 
> Can we have a tesT?

You do have one. Check bug 88101. :)

> 
> > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1158
> > +    if (d->colorChooser == colorChooser)
> > +        return;
> 
> we normally add newline after return

Gonna fix it.

Thanks for reviewing.

[Thiago Marcos P. Santos]

Created attachment 147302 [details]
Patch v2

[Thiago Marcos P. Santos]

Created attachment 147547 [details]
Patch

Rebased.

[WebKit Review Bot]

Comment on attachment 147547 [details]
Patch

Clearing flags on attachment: 147547

Committed r120915: <http://trac.webkit.org/changeset/120915>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.