Bug 87925 - [V8] Expando properties on attribute nodes disappear
Summary: [V8] Expando properties on attribute nodes disappear
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominic Cooney
URL:
Keywords:
Depends on: 88045 88062
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-30 22:01 PDT by Dominic Cooney
Modified: 2012-09-11 23:11 PDT (History)
6 users (show)

See Also:


Attachments
Repro. Must run Chrome with --js-flags=--expose_gc. (533 bytes, text/html)
2012-05-30 22:01 PDT, Dominic Cooney
no flags Details
Patch (5.15 KB, patch)
2012-05-31 21:46 PDT, Dominic Cooney
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Cooney 2012-05-30 22:01:19 PDT
Created attachment 144983 [details]
Repro. Must run Chrome with --js-flags=--expose_gc.

Object grouping for attribute nodes is incorrect. See the attached repro. It should print "magic", "magic" but because the attribute node wrapper is collected prematurely, it prints "magic", "undefined".
Comment 1 Dominic Cooney 2012-05-31 21:46:29 PDT
Created attachment 145208 [details]
Patch
Comment 2 Dominic Cooney 2012-05-31 21:47:19 PDT
Comment on attachment 145208 [details]
Patch

Filed bug 88045 for JSC. It seems the same bug exists in JSC bindings.
Comment 3 Adam Barth 2012-05-31 22:13:31 PDT
Comment on attachment 145208 [details]
Patch

LGTM.  You might want to run this patch by haraken before landing.
Comment 4 Kentaro Hara 2012-05-31 22:26:59 PDT
Comment on attachment 145208 [details]
Patch

LGTM from me too
Comment 5 WebKit Review Bot 2012-05-31 23:37:22 PDT
Comment on attachment 145208 [details]
Patch

Clearing flags on attachment: 145208

Committed r119196: <http://trac.webkit.org/changeset/119196>
Comment 6 WebKit Review Bot 2012-05-31 23:37:30 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 János Badics 2012-06-01 01:25:32 PDT
A newly added test (fast/dom/gc-attribute-node.html) fails on Qt, GTK and EFL 64 bit since r119196. I will skip this test until the problem is solved.
https://bugs.webkit.org/show_bug.cgi?id=88062