Bug 87830 - Web Inspector: add MemoryUsageSupport::processMemoryUsageBytes
Summary: Web Inspector: add MemoryUsageSupport::processMemoryUsageBytes
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
Depends on: 80787
  Show dependency treegraph
Reported: 2012-05-30 00:26 PDT by Yury Semikhatsky
Modified: 2012-05-31 00:33 PDT (History)
17 users (show)

See Also:

Patch (8.61 KB, patch)
2012-05-30 00:32 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch (8.63 KB, patch)
2012-05-30 00:38 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch (8.63 KB, patch)
2012-05-30 01:03 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch (8.61 KB, patch)
2012-05-30 02:16 PDT, Yury Semikhatsky
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-05-30 00:26:33 PDT
We need to know process memory usage to show it in the inspector. It is now exposed on Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h which is Chromium-specific file. We need a more portable approach here.
Comment 1 Yury Semikhatsky 2012-05-30 00:32:27 PDT
Created attachment 144735 [details]
Comment 2 Yury Semikhatsky 2012-05-30 00:33:04 PDT
(In reply to comment #1)
> Created an attachment (id=144735) [details]
> Patch

This patch addresses Tony's comments on http://codereview.chromium.org/9669039/diff/5/webkit/glue/webkitplatformsupport_impl.h
Comment 3 WebKit Review Bot 2012-05-30 00:35:55 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Yury Semikhatsky 2012-05-30 00:38:21 PDT
Created attachment 144736 [details]
Comment 5 Yury Semikhatsky 2012-05-30 01:03:25 PDT
Created attachment 144742 [details]
Comment 6 Build Bot 2012-05-30 01:32:04 PDT
Comment on attachment 144742 [details]

Attachment 144742 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12843770
Comment 7 Yury Semikhatsky 2012-05-30 02:16:10 PDT
Created attachment 144759 [details]
Comment 8 James Robinson 2012-05-30 09:44:08 PDT
Comment on attachment 144759 [details]

Seems pretty reasonable to me
Comment 9 Adam Barth 2012-05-30 11:32:10 PDT
Comment on attachment 144759 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=144759&action=review

> Source/WebCore/inspector/InspectorMemoryAgent.cpp:-342

Yay removing #if CHROMIUM
Comment 10 Yury Semikhatsky 2012-05-31 00:33:36 PDT
Committed r119068: <http://trac.webkit.org/changeset/119068>