Bug 87814 - [V8] Implement V8Binding::v8BooleanWithCheck(isolate)
Summary: [V8] Implement V8Binding::v8BooleanWithCheck(isolate)
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Blocks: 84074
  Show dependency treegraph
Reported: 2012-05-29 20:57 PDT by Kentaro Hara
Modified: 2012-05-30 17:29 PDT (History)
3 users (show)

See Also:

Patch (6.61 KB, patch)
2012-05-29 21:03 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-05-29 20:57:18 PDT
The objective is to pass Isolate to v8::True() and v8::False(). Similarly to v8NullWithCheck() (bug 87713), we can implement V8Binding::v8BooleanWithCheck(isolate), which calls v8::True()/v8::False() or v8::True(isolate)/v8::False(isolate) depending on whether the passed isolate is null or not.
Comment 1 Kentaro Hara 2012-05-29 21:03:46 PDT
Created attachment 144688 [details]
Comment 2 WebKit Review Bot 2012-05-30 17:29:52 PDT
Comment on attachment 144688 [details]

Clearing flags on attachment: 144688

Committed r119003: <http://trac.webkit.org/changeset/119003>
Comment 3 WebKit Review Bot 2012-05-30 17:29:56 PDT
All reviewed patches have been landed.  Closing bug.