Bug 87814 - [V8] Implement V8Binding::v8BooleanWithCheck(isolate)
Summary: [V8] Implement V8Binding::v8BooleanWithCheck(isolate)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 84074
  Show dependency tree / graph
 
Reported: 2012-05-29 20:57 PDT by Kentaro Hara
Modified: 2012-05-30 17:29 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.61 KB, patch)
2012-05-29 21:03 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-05-29 20:57:18 PDT 
The objective is to pass Isolate to v8::True() and v8::False(). Similarly to v8NullWithCheck() (bug 87713), we can implement V8Binding::v8BooleanWithCheck(isolate), which calls v8::True()/v8::False() or v8::True(isolate)/v8::False(isolate) depending on whether the passed isolate is null or not.
Comment 1 Kentaro Hara 2012-05-29 21:03:46 PDT 
Created attachment 144688 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-30 17:29:52 PDT 
Comment on attachment 144688 [details]
Patch

Clearing flags on attachment: 144688

Committed r119003: <http://trac.webkit.org/changeset/119003>
Comment 3 WebKit Review Bot 2012-05-30 17:29:56 PDT 
All reviewed patches have been landed.  Closing bug.