Leverage the new WebOverlay API to move SelectionOverlay to the WebKit library, so we always draw selection regardless of which embedder is integrating WebKit. Please note that this has not been internally reviewed yet, so it needs actual review. And also, it has a dependency that needs to be landed first.
Created attachment 144252 [details] Patch
PR #160263
Comment on attachment 144252 [details] Patch Looks good to me.
Comment on attachment 144252 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144252&action=review Looks good. > Source/WebKit/blackberry/WebKitSupport/SelectionOverlay.cpp:32 > +#include <SkCornerPathEffect.h> Is this used?
(In reply to comment #4) > (From update of attachment 144252 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144252&action=review > > Looks good. > > > Source/WebKit/blackberry/WebKitSupport/SelectionOverlay.cpp:32 > > +#include <SkCornerPathEffect.h> > > Is this used? Oops, no it's not - I will upload a new patch
Created attachment 144400 [details] Patch
Comment on attachment 144400 [details] Patch Looks good.
Comment on attachment 144400 [details] Patch Clearing flags on attachment: 144400 Committed r118785: <http://trac.webkit.org/changeset/118785>
All reviewed patches have been landed. Closing bug.