Bug 87604 - [BlackBerry] Make DefaultTapHighlight use the new WebOverlay API
Summary: [BlackBerry] Make DefaultTapHighlight use the new WebOverlay API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Arvid Nilsson
URL:
Keywords:
Depends on: 87603
Blocks: 87605
  Show dependency tree / graph
 
Reported: 2012-05-27 15:10 PDT by Arvid Nilsson
Modified: 2012-05-29 10:51 PDT (History)
8 users (show)

See Also:

Attachments
Patch (9.27 KB, patch)
2012-05-27 16:33 PDT, Arvid Nilsson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Nilsson 2012-05-27 15:10:21 PDT 
and add a new method to allow the embedder to use the default tap highlight instead of replacing it with a custom one just to keep track of the "shouldHideAfterScroll" flag.

Please note that this has not been internally reviewed yet, so it needs actual review. And also, it has a dependency that needs to be landed first.
Comment 1 Arvid Nilsson 2012-05-27 16:33:24 PDT 
Created attachment 144250 [details]
Patch
Comment 2 Arvid Nilsson 2012-05-27 16:53:55 PDT 
PR 160262
Comment 3 Rob Buis 2012-05-29 07:32:54 PDT 
Comment on attachment 144250 [details]
Patch

Looks good.
Comment 4 WebKit Review Bot 2012-05-29 10:51:16 PDT 
Comment on attachment 144250 [details]
Patch

Clearing flags on attachment: 144250

Committed r118805: <http://trac.webkit.org/changeset/118805>
Comment 5 WebKit Review Bot 2012-05-29 10:51:21 PDT 
All reviewed patches have been landed.  Closing bug.