Bug 87534 – [EFL] [DRT] Reset CacheModel before running each test

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Sudarsana Nagineni (babu)]

Reset CacheModel before running each test to fix some flakiness on EFL build bots.

fast/dom/StyleSheet/detached-style-2.html
fast/dom/StyleSheet/detached-style-pi-2.xhtml
fast/dom/StyleSheet/detached-style-pi.xhtml
fast/dom/StyleSheet/detached-style.html

[Sudarsana Nagineni (babu)]

Created attachment 144157 [details]
patch

Reset cache model before running each test to fix some flaky tests.

[Raphael Kubo da Costa (:rakuco)]

Nice that Mikhail is already CC'ed; https://bugs.webkit.org/show_bug.cgi?id=86840#c4 says these settings should be already being reset. Isn't that the case?

[Sudarsana Nagineni (babu)]

They are not reset to default on the test startup. memory_cache_clear() clears the page cache and reset to the previous value. So, we need to reset the values to default to avoid any flakiness.

[Mikhail Pozdnyakov]

(In reply to comment #2)
> Nice that Mikhail is already CC'ed; https://bugs.webkit.org/show_bug.cgi?id=86840#c4 says these settings should be already being reset. Isn't that the case?

My bad :( we've discussed it with Babu memory_cache_clear() is not enough actually.

[Chris Dumez]

Comment on attachment 144157 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144157&action=review

> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:273
> +    unsigned cacheTotalCapacity =  8192 * 1024;

Small nit: We could mark this variable as const.

[Mikhail Pozdnyakov]

(In reply to comment #5)
> (From update of attachment 144157 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144157&action=review
> > Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:273
> > +    unsigned cacheTotalCapacity =  8192 * 1024;
> Small nit: We could mark this variable as const.

And static..

[Caio Marcelo de Oliveira Filho]

Comment on attachment 144157 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144157&action=review

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:550
> -    case 3: // WebCacheModelPrimaryWebBrowser
> +    case 2: // WebCacheModelPrimaryWebBrowser

Nit pick: the fact that each number have a comment with a name suggests that we could have an enum, even if it needs to be synchronized. It would also have avoided the typo you're fixing now.

[Sudarsana Nagineni (babu)]

Created attachment 144568 [details]
Patch

fixed review comments.

[WebKit Review Bot]

Comment on attachment 144568 [details]
Patch

Clearing flags on attachment: 144568

Committed r120001: <http://trac.webkit.org/changeset/120001>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.