Bug 86840 – [EFL][DRT] LayoutTestController's setCacheModel() implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Mikhail Pozdnyakov]

WebKit EFL needs support of different cache models so that the client has opportunity to set the appropriate one providing desired  memory usage or document load speed.
Also it will enable LayoutTestController's setCacheModel() function and hence unskip fast/dom/HTMLScriptElement/nested-execution.html testcase.

[Mikhail Pozdnyakov]

(In reply to comment #0)
> WebKit EFL needs support of different cache models so that the client has opportunity to set the appropriate one providing desired  memory usage or document load speed.
> Also it will enable LayoutTestController's setCacheModel() function and hence unskip fast/dom/HTMLScriptElement/nested-execution.html testcase.

Choosing of a cache model would lead to 3 web core function invokes:
1)  memoryCache()->setCapacities();
2)  memoryCache()->setDeadDecodedDataDeletionInterval();
3)  pageCache()->setCapacity();

1 - is already exported in ewk_settings (ewk_settings_object_cache_capacity_set)
2 - is not exported, and no other port is exporting it explicitly, so would rather put it to DRT support yet just to make tests pass (could be exported later if needed).
3 - is to be exported as clients should be interested in setting page cache capacity (will file a separate bug for it).

[Mikhail Pozdnyakov]

Created attachment 143056 [details]
patch

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 143056 [details]
patch

Don't you need to reset these settings after each test?

[Mikhail Pozdnyakov]

(In reply to comment #3)
> (From update of attachment 143056 [details])
> Don't you need to reset these settings after each test?

memoryCache()->setDeadDecodedDataDeletionInterval(); is reset with DumpRenderTreeSupportEfl::setDeadDecodedDataDeletionInterval(0);

The rest is reset with  ewk_settings_memory_cache_clear();
that was already invoked.

[Raphael Kubo da Costa (:rakuco)]

OK, then I guess it looks fine.

[Csaba Osztrogonác]

Comment on attachment 143056 [details]
patch

rs=me

[WebKit Review Bot]

Comment on attachment 143056 [details]
patch

Rejecting attachment 143056 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
pportEfl.h
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp
Hunk #1 FAILED at 257.
1 out of 1 hunk FAILED -- saving rejects to file Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp.rej
patching file Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Csaba Oszt..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12800104

[Mikhail Pozdnyakov]

Created attachment 143761 [details]
to be landed.

[WebKit Review Bot]

Comment on attachment 143761 [details]
to be landed.

Rejecting attachment 143761 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12791153

[Gyuyoung Kim]

Comment on attachment 143761 [details]
to be landed.

View in context: https://bugs.webkit.org/attachment.cgi?id=143761&action=review

> LayoutTests/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Change NOBODY with reviewer name.

[Mikhail Pozdnyakov]

Created attachment 143773 [details]
to be landed. (Added reviewer name to changelog)

[WebKit Review Bot]

Comment on attachment 143773 [details]
to be landed. (Added reviewer name to changelog)

Rejecting attachment 143773 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Csaba Osztrogonac found in /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12799134

[Mikhail Pozdnyakov]

Created attachment 143780 [details]
to be landed. (trying again :( )

[WebKit Review Bot]

Comment on attachment 143780 [details]
to be landed. (trying again :( )

Clearing flags on attachment: 143780

Committed r118366: <http://trac.webkit.org/changeset/118366>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.