Bug 87498 - [EFL] Enable DOWNLOAD_ATTRIBUTE on EFL port
Summary: [EFL] Enable DOWNLOAD_ATTRIBUTE on EFL port
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
: 93483 (view as bug list)
Depends on: 85363
Blocks:
  Show dependency tree / graph
 
Reported: 2012-05-25 06:46 PDT by Chris Dumez
Modified: 2012-08-21 22:05 PDT (History)
6 users (show)

See Also:

Attachments
Patch (10.47 KB, patch)
2012-05-25 06:58 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-05-25 06:46:52 PDT 
DOWNLOAD_ATTRIBUTE flags needs to be enabled on EFL port to unskip:
  fast/dom/HTMLAnchorElement/anchor-download-unset.html
  fast/dom/HTMLAnchorElement/anchor-download.html
  fast/dom/HTMLAnchorElement/anchor-nodownload-set.html
  fast/dom/HTMLAnchorElement/anchor-nodownload.html

This also requires the BLOB flag to be enabled.
Comment 1 Chris Dumez 2012-05-25 06:58:06 PDT 
Created attachment 144061 [details]
Patch
Comment 2 Gyuyoung Kim 2012-05-25 17:37:32 PDT 
Comment on attachment 144061 [details]
Patch

Looks good to me.
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-05-29 06:57:32 PDT 
Comment on attachment 144061 [details]
Patch

Looks fine, please just rebase after the BLOB support got in.
Comment 4 Gyuyoung Kim 2012-08-10 04:58:07 PDT 
*** Bug 93483 has been marked as a duplicate of this bug. ***
Comment 5 Gyuyoung Kim 2012-08-10 04:58:35 PDT 
Any update ?
Comment 6 Gyuyoung Kim 2012-08-21 20:22:17 PDT 
Comment on attachment 144061 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144061&action=review

> Source/cmake/OptionsEfl.cmake:69
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BLOB ON)

BLOB feature is already enabled. I think blob feature needs to be removed from this patch.

> Tools/ChangeLog:16
> +        * Scripts/webkitperl/FeatureList.pm: Enable BLOB and

ditto.

> Tools/Scripts/webkitperl/FeatureList.pm:143
> +      define => "ENABLE_BLOB", default => (isAppleMacWebKit() || isGtk() || isChromium() || isBlackBerry() || isEfl()), value => \$blobSupport },

ditto.