WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
87498
[EFL] Enable DOWNLOAD_ATTRIBUTE on EFL port
https://bugs.webkit.org/show_bug.cgi?id=87498
Summary
[EFL] Enable DOWNLOAD_ATTRIBUTE on EFL port
Chris Dumez
Reported
2012-05-25 06:46:52 PDT
DOWNLOAD_ATTRIBUTE flags needs to be enabled on EFL port to unskip: fast/dom/HTMLAnchorElement/anchor-download-unset.html fast/dom/HTMLAnchorElement/anchor-download.html fast/dom/HTMLAnchorElement/anchor-nodownload-set.html fast/dom/HTMLAnchorElement/anchor-nodownload.html This also requires the BLOB flag to be enabled.
Attachments
Patch
(10.47 KB, patch)
2012-05-25 06:58 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2012-05-25 06:58:06 PDT
Created
attachment 144061
[details]
Patch
Gyuyoung Kim
Comment 2
2012-05-25 17:37:32 PDT
Comment on
attachment 144061
[details]
Patch Looks good to me.
Raphael Kubo da Costa (:rakuco)
Comment 3
2012-05-29 06:57:32 PDT
Comment on
attachment 144061
[details]
Patch Looks fine, please just rebase after the BLOB support got in.
Gyuyoung Kim
Comment 4
2012-08-10 04:58:07 PDT
***
Bug 93483
has been marked as a duplicate of this bug. ***
Gyuyoung Kim
Comment 5
2012-08-10 04:58:35 PDT
Any update ?
Gyuyoung Kim
Comment 6
2012-08-21 20:22:17 PDT
Comment on
attachment 144061
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=144061&action=review
> Source/cmake/OptionsEfl.cmake:69 > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BLOB ON)
BLOB feature is already enabled. I think blob feature needs to be removed from this patch.
> Tools/ChangeLog:16 > + * Scripts/webkitperl/FeatureList.pm: Enable BLOB and
ditto.
> Tools/Scripts/webkitperl/FeatureList.pm:143 > + define => "ENABLE_BLOB", default => (isAppleMacWebKit() || isGtk() || isChromium() || isBlackBerry() || isEfl()), value => \$blobSupport },
ditto.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug