WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
85363
[EFL] Enable blob support for the EFL port
https://bugs.webkit.org/show_bug.cgi?id=85363
Summary
[EFL] Enable blob support for the EFL port
Sudarsana Nagineni (babu)
Reported
2012-05-02 04:07:20 PDT
Turn on blob support for the EFL port.
Attachments
Patch
(4.53 KB, patch)
2012-05-25 08:15 PDT
,
Sudarsana Nagineni (babu)
no flags
Details
Formatted Diff
Diff
Patch
(6.01 KB, patch)
2012-05-26 02:38 PDT
,
Sudarsana Nagineni (babu)
no flags
Details
Formatted Diff
Diff
Patch
(6.04 KB, patch)
2012-05-26 02:44 PDT
,
Sudarsana Nagineni (babu)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Sudarsana Nagineni (babu)
Comment 1
2012-05-25 08:15:12 PDT
Created
attachment 144073
[details]
Patch Enable Blob support by default.
Raphael Kubo da Costa (:rakuco)
Comment 2
2012-05-25 16:02:11 PDT
Comment on
attachment 144073
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=144073&action=review
> LayoutTests/ChangeLog:10 > + * platform/efl/test_expectations.txt:
IIRC there are also quite a few blob-related tests in Skipped. Have you checked if any of them passes now?
Sudarsana Nagineni (babu)
Comment 3
2012-05-26 02:17:18 PDT
(In reply to
comment #2
)
> > LayoutTests/ChangeLog:10 > > + * platform/efl/test_expectations.txt: > > IIRC there are also quite a few blob-related tests in Skipped. Have you checked if any of them passes now?
I checked some of the blob related tests which are under beginDragWithFiles section in Skipped file and they are still failing. It seems there are few more tests which needs to be checked. I'm going to do that and update the patch based on the results.
Sudarsana Nagineni (babu)
Comment 4
2012-05-26 02:38:00 PDT
Created
attachment 144198
[details]
Patch Unskip passing tests from Skipped file.
Sudarsana Nagineni (babu)
Comment 5
2012-05-26 02:44:35 PDT
Created
attachment 144199
[details]
Patch Updated changelog.
Hajime Morrita
Comment 6
2012-05-27 19:00:41 PDT
Comment on
attachment 144199
[details]
Patch rubberstamping.
Gyuyoung Kim
Comment 7
2012-05-27 21:01:22 PDT
Comment on
attachment 144199
[details]
Patch Looks good to me.
WebKit Review Bot
Comment 8
2012-05-27 22:00:45 PDT
Comment on
attachment 144199
[details]
Patch Clearing flags on attachment: 144199 Committed
r118647
: <
http://trac.webkit.org/changeset/118647
>
WebKit Review Bot
Comment 9
2012-05-27 22:00:50 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug