Bug 87491 - [CSS Regions]Rename NamedFlow::overflow to NamedFlow::overset
Summary: [CSS Regions]Rename NamedFlow::overflow to NamedFlow::overset
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 87640
  Show dependency tree / graph
 
Reported: 2012-05-25 04:57 PDT by Andrei Bucur
Modified: 2012-05-29 06:40 PDT (History)
4 users (show)

See Also:

Attachments
Patch and test (13.94 KB, patch)
2012-05-28 03:36 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Updated patch and test that actually applies (28.03 KB, patch)
2012-05-28 07:50 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
The final version of the patch (28.03 KB, patch)
2012-05-28 08:10 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Patch that's not actually grabbed from browser cache... (28.03 KB, patch)
2012-05-28 08:14 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Patch (14.83 KB, patch)
2012-05-28 08:21 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Patch (15.20 KB, patch)
2012-05-29 02:34 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Bucur 2012-05-25 04:57:01 PDT 
The CSS Regions spec renamed the CSSOM property "overflow" available on the NamedFlow object to "overset". WebKit needs to update the name as well.
Comment 1 Andrei Bucur 2012-05-28 03:36:23 PDT 
Created attachment 144321 [details]
Patch and test
Comment 2 Andrei Bucur 2012-05-28 07:50:47 PDT 
Created attachment 144359 [details]
Updated patch and test that actually applies
Comment 3 Andrei Bucur 2012-05-28 08:10:11 PDT 
Created attachment 144363 [details]
The final version of the patch
Comment 4 Andrei Bucur 2012-05-28 08:14:07 PDT 
Created attachment 144365 [details]
Patch that's not actually grabbed from browser cache...
Comment 5 Andrei Bucur 2012-05-28 08:21:31 PDT 
Created attachment 144369 [details]
Patch
Comment 6 Andrei Bucur 2012-05-28 08:54:32 PDT 
The relevant spec info:
http://www.w3.org/TR/2012/WD-css3-regions-20120503/#dom-named-flow
Comment 7 Andreas Kling 2012-05-28 08:58:18 PDT 
Comment on attachment 144369 [details]
Patch

r=me, but please add the spec link to the ChangeLog, as well as a little blurb saying that this is the correct new property name per the spec.
Comment 8 Andrei Bucur 2012-05-29 02:34:25 PDT 
Created attachment 144491 [details]
Patch
Comment 9 WebKit Review Bot 2012-05-29 06:40:11 PDT 
Comment on attachment 144491 [details]
Patch

Clearing flags on attachment: 144491

Committed r118767: <http://trac.webkit.org/changeset/118767>
Comment 10 WebKit Review Bot 2012-05-29 06:40:17 PDT 
All reviewed patches have been landed.  Closing bug.