Once we get the testing functional, make it a step on EFL the bots.
Created attachment 150421 [details] Patch
Comment on attachment 150421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150421&action=review > Tools/Scripts/run-efl-tests:38 > +$ENV{CTEST_OUTPUT_ON_FAILURE}="1"; Nit: Missing space characters on both sides of the equality sign (=). > Tools/Scripts/run-efl-tests:41 > +exit exitStatus(0); This line isn't necessary as Perl exits with exit status 0 by default.
Created attachment 150474 [details] Patch v2 This new version fixes the issues pointed by the review. I'm going to test tomorrow on a buildslave before asking cq just to be sure. Thanks for reviewing
Comment on attachment 150474 [details] Patch v2 Rejecting attachment 150474 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: s/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg Hunk #1 succeeded at 490 (offset 3 lines). Hunk #2 FAILED at 737. Hunk #3 FAILED at 766. 2 out of 3 hunks FAILED -- saving rejects to file Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg.rej patching file Tools/Scripts/run-efl-tests Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13129478
Created attachment 150595 [details] Patch Rebased.
Comment on attachment 150595 [details] Patch Clearing flags on attachment: 150595 Committed r121768: <http://trac.webkit.org/changeset/121768>
All reviewed patches have been landed. Closing bug.